fix: Default tab selected issue#9546
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Someone is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Udit-takkar
left a comment
Udit-takkar
left a comment
There was a problem hiding this comment.
@VinoV1999 LGTM. I have simplified the code
|
@Udit-takkar yes it's looks simple. But that causes below issues. Screen.Recording.2023-06-16.at.9.15.08.AM.movBasically resetFields() is getting called even the server throws exception. steps to reproducehttps://github.com/calcom/cal.com/blob/main/packages/trpc/server/routers/viewer/teams/_router.tsx
FYI: This is to interrupt the flow of server. |
CarinaWolli
changed the title
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Udit-takkar
force-pushed
the
VinoV1999/default-tab-selected-issue
branch
from
3429c47 to
f396e7d
Compare
| }), | ||
| "success" | ||
| ); | ||
| resetFields(); |
There was a problem hiding this comment.
moved onSuccess here to call resetFields
sean-brydon
left a comment
sean-brydon
left a comment
There was a problem hiding this comment.
Nice! i was actually just fixing this locally for another PR :) Great job
Co-authored-by: Alex van Andel <me@alexvanandel.com>
* default tab selected issue * refactor: improve cde Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * fix: use onSuccess Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * fix: move onsuccess and onerror Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> --------- Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Vinoth Kumar V <vinoth_kumar_v@Vinoths-MacBook-Pro.local> Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
4 participants
What does this PR do?
Fixes the bulk import components rendering but individual invite tab has been selected issue.
Fixes #9490
Screen.Recording.2023-06-15.at.9.03.37.PM.mov
Type of change
Note : The reason to get a function from child to parent and called it in onSuccess function is to avoid clearing the inputs before the service is getting called. That prevents the data if services are down.