fix: Adding more time to org admin email verif step#9574
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-brydon
approved these changes
Jun 16, 2023
emrysal
changed the title
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 98 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/16/2023 02:38:00pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: dbab6f3 Started: 06/16/2023 02:36:15pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
4.83% (13)13 / 269 runsfailed over last 7 days |
15.99% (43)43 / 269 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully login flow user & logout using dashboard
Retry 1 • Initial Attempt |
5.82% (16)16 / 275 runsfailed over last 7 days |
28.73% (79)79 / 275 runsflaked over last 7 days |
📄 apps/web/playwright/change-password.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Change Password Test change password
Retry 1 • Initial Attempt |
0% (0)0 / 263 runsfailed over last 7 days |
1.14% (3)3 / 263 runsflaked over last 7 days |
1 task
iamr-kumar
pushed a commit
to iamr-kumar/cal.com
that referenced
this pull request
Jun 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Making the organization admin email verification code sent valid for 15 minutes. It was 90 seconds, not enough for people to get the email and use the code successfully.
Type of change
How should this be tested?
When creating an org, the step to verify your email will send you an email with a code. That code should be valid for 15 minutes.
Mandatory Tasks