fix: Push mini calendar down in week / column view#9628
Merged
Conversation
…r. Tested in Chrome, FF and Safari.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JeroenReumkens
changed the title
JeroenReumkens
commented
Jun 19, 2023
| )}> | ||
| <BookerSection | ||
| area="meta" | ||
| className="max-w-screen flex h-full w-full flex-col md:w-[var(--booker-meta-width)]"> |
Contributor
Author
There was a problem hiding this comment.
This incorrectly limited the meta side column height if contents was smaller than screen.
sean-brydon
approved these changes
Jun 19, 2023
PeerRich
approved these changes
Jun 19, 2023
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 98 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/19/2023 01:13:41pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 7bd659c Started: 06/19/2023 01:09:23pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully login flow user & logout using dashboard
Retry 1 • Initial Attempt |
4.48% (13)13 / 290 runsfailed over last 7 days |
37.93% (110)110 / 290 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- old-booker can add multiple organizer address
Retry 1 • Initial Attempt |
1.42% (4)4 / 281 runsfailed over last 7 days |
28.47% (80)80 / 281 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
FORM_SUBMITTED can submit a form and get a submission event
Retry 1 • Initial Attempt |
4.35% (9)9 / 207 runsfailed over last 7 days |
15.94% (33)33 / 207 runsflaked over last 7 days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removed full height which incorrectly limited height in booker sidebar. Tested in Chrome, FF and Safari.
Before
After
Type of change
How should this be tested?