feat: Add divider and set spacing on modals with the type=creation prop (feat-add-divider)#9629
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 120 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/26/2023 10:45:13pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: a7588ca Started: 06/26/2023 10:43:21pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
pro user -- old-booker can reschedule a booking
Retry 1 • Initial Attempt |
3.37% (11)11 / 326 runsfailed over last 7 days |
3.99% (13)13 / 326 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 2 • Retry 1 • Initial Attempt |
6.05% (13)13 / 215 runsfailed over last 7 days |
33.95% (73)73 / 215 runsflaked over last 7 days |
| <DialogFooter | ||
| className="mt-8 flex flex-row-reverse gap-x-2" | ||
| showDivider | ||
| customDividerClassNames="w-2/3"> |
There was a problem hiding this comment.
In this specific case we had to implement this to the divider fill only the desired component space:
Without this prop:
There was a problem hiding this comment.
The divider should not cross into the gray part on the left ideally
There was a problem hiding this comment.
Ok we did this, the screenshot above is just to show why we need this prop we added 😄
| <div> | ||
| <div className="flex"> | ||
| <code className="bg-subtle text-default mb-2 w-full truncate rounded-md rounded-r-none py-[6px] pl-2 pr-2 align-middle font-mono"> | ||
| <code className="bg-subtle text-default w-full truncate rounded-md rounded-r-none py-[6px] pl-2 pr-2 align-middle font-mono"> |
There was a problem hiding this comment.
The "mb-2" className was removed to fix this wrong input size
|
what is the original issue? can you link it by commenting "fixes #number" |
|
Overall this looks great. The only thing that looks off to me is the spacing above and below the body.. ie how the body content is spaced from the header and the footer. 
|
|
The following modals have Inter as the header instead of Cal Sans
The following modals have the primary & secondary buttons order reversed (primary should be on the right):
In designs, the button that sits alongside the primary button always use the minimal style. It appears here we're using secondary for Cancel and minimal for Close. I think we can just make those the same but no strong feelings on that one. |
|
Thank you for following the naming conventions! 🙏 |
|
Hi @Jaibles we made the changes here, please take a look 😄 |
sean-brydon
left a comment
sean-brydon
left a comment
There was a problem hiding this comment.
I've double checked against @Jaibles comments and not noticed anything wrong. Thanks @gitstart-calcom will approve and if we notice anything else will create a issue to follow up.
Great work
|
@sean-brydon merged this pull request with Graphite. |
5 participants
What does this PR do?
Inline Embed:
Enable Two-Factor Authentication:
-Enable Two-Factor Authentication (step 2):
-Enable Two-Factor Authentication (step 3):
Disable Two-Factor Authentication:
Delete Account:
Update Timezone:
Duplicate Event Type:
Add a New Form:
Change Team Member Role:
Impersonate:
Bulk Update Event Types:
Connecting with MS Teams:
Set a Default App Link:
OIDC configuration:
SAML Configuration:
How to use booking questions as variables?
Invite Link Settings:
Add Action:
Edit Keys:
Create an Api Key:
API key created successfully:
Invite Team Member:
Add a Question:
Add a new event type:
