Skip to content

fix: Fixed bg color for all booked days as per design#9630

Merged
emrysal merged 2 commits into
mainfrom
feat/fix-bg-calendar-for-all-booked
Jun 20, 2023
Merged

fix: Fixed bg color for all booked days as per design#9630
emrysal merged 2 commits into
mainfrom
feat/fix-bg-calendar-for-all-booked

Conversation

@JeroenReumkens
Copy link
Copy Markdown
Contributor

What does this PR do?

Improves bg color for all booked days as per design.
Ignore the mini calendar not pushed to the bottom, that's fixed in a different PR :) Extending the 'all booked' block for the full height is also fixed in an earlier PR.

Fixes CAL-1904

Light mode

CleanShot 2023-06-19 at 15 03 25@2x

Dark mode

CleanShot 2023-06-19 at 15 06 03@2x

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@linear
Copy link
Copy Markdown

linear Bot commented Jun 19, 2023

CAL-1904 Column view: No slots available - height issue & bg nit

Currently they vary

CleanShot 2023-06-07 at 10.09.222x.png

For this scenario we should have a more reasonable min-height, probably 3 times what's there.

CleanShot 2023-06-07 at 10.07.212x.png

Should go full height, or at least just to the end of the nearest dates

CleanShot 2023-06-07 at 10.08.392x.png

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 0:08am
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 0:08am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 0:08am
web-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 0:08am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 19, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jun 19, 2023

Current Playwright Test Results Summary

✅ 98 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/20/2023 12:21:05am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: ea0afcc

Started: 06/20/2023 12:17:32am UTC

⚠️ Flakes

📄   apps/web/playwright/reschedule.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule Tests -- new-booker Unpaid rescheduling should go to payment page
Retry 1Initial Attempt
1.74% (5) 5 / 287 runs
failed over last 7 days
0.70% (2) 2 / 287 runs
flaked over last 7 days

📄   apps/web/playwright/change-password.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Change Password Test change password
Retry 1Initial Attempt
0% (0) 0 / 288 runs
failed over last 7 days
1.74% (5) 5 / 288 runs
flaked over last 7 days

View Detailed Build Results


@github-actions
Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants