Skip to content

fix: Fallback for older event types without owner#9638

Merged
zomars merged 1 commit into
mainfrom
bugfix/fallback-owner-to-users-arr
Jun 19, 2023
Merged

fix: Fallback for older event types without owner#9638
zomars merged 1 commit into
mainfrom
bugfix/fallback-owner-to-users-arr

Conversation

@emrysal
Copy link
Copy Markdown
Contributor

@emrysal emrysal commented Jun 19, 2023

What does this PR do?

Re-implements the fallback for the users array

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 3:21pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 3:21pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 3:21pm
web-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 3:21pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 19, 2023

Thank you for following the naming conventions! 🙏

@emrysal emrysal changed the title Created secondary function to read the owner from users array fix: Fallback for older event types without owner Jun 19, 2023
@emrysal emrysal marked this pull request as ready for review June 19, 2023 15:02
@emrysal emrysal requested a review from JeroenReumkens June 19, 2023 15:03
@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jun 19, 2023

Current Playwright Test Results Summary

✅ 98 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/19/2023 03:10:15pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 6a77ea5

Started: 06/19/2023 03:08:10pm UTC

⚠️ Flakes

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 2Retry 1Initial Attempt
1.01% (3) 3 / 296 runs
failed over last 7 days
19.93% (59) 59 / 296 runs
flaked over last 7 days

📄   apps/web/playwright/login.2fa.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
3.39% (10) 10 / 295 runs
failed over last 7 days
13.22% (39) 39 / 295 runs
flaked over last 7 days
2FA Tests should allow a user to disable 2FA
Retry 1Initial Attempt
3.39% (10) 10 / 295 runs
failed over last 7 days
27.46% (81) 81 / 295 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user -- old-booker can add multiple organizer address
Retry 1Initial Attempt
1.37% (4) 4 / 292 runs
failed over last 7 days
29.45% (86) 86 / 292 runs
flaked over last 7 days

View Detailed Build Results


@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@zomars zomars merged commit 3611082 into main Jun 19, 2023
@zomars zomars deleted the bugfix/fallback-owner-to-users-arr branch June 19, 2023 15:53
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants