Skip to content

fix: Org labels, url prefix and typos [CAL-1999] [CAL-2000] [CAL-2001]#9646

Merged
alannnc merged 1 commit into
mainfrom
fix/org-labels-typos
Jun 19, 2023
Merged

fix: Org labels, url prefix and typos [CAL-1999] [CAL-2000] [CAL-2001]#9646
alannnc merged 1 commit into
mainfrom
fix/org-labels-typos

Conversation

@leog
Copy link
Copy Markdown
Contributor

@leog leog commented Jun 19, 2023

What does this PR do?

Some labels were not org aware and some typos referring to organization with "s"

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Go to Org profile and see name and URL labels refer to orgs now, and URL prefix corrected

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@linear
Copy link
Copy Markdown

linear Bot commented Jun 19, 2023

CAL-1999 Org setting profile team name label

Should read organization name

CAL-2000 Org setting profile team URL label

Should read "Organization URL"

CAL-2001 Org setting profile URL prefix is wrong

Should take into account org subdomain to show the correct URL

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 8:07pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 8:07pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 8:07pm
web-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 8:07pm

@leog leog requested a review from a team June 19, 2023 20:00
@leog leog self-assigned this Jun 19, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jun 19, 2023

Current Playwright Test Results Summary

✅ 114 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/19/2023 08:11:34pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 9652a3b

Started: 06/19/2023 08:09:29pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user -- old-booker can add multiple organizer address
Retry 1Initial Attempt
1.29% (4) 4 / 309 runs
failed over last 7 days
29.45% (91) 91 / 309 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Router URL should work
Retry 1Initial Attempt
0% (0) 0 / 190 runs
failed over last 7 days
1.05% (2) 2 / 190 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully login flow user & logout using dashboard
Retry 1Initial Attempt
4.08% (13) 13 / 319 runs
failed over last 7 days
39.18% (125) 125 / 319 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
8.85% (17) 17 / 192 runs
failed over last 7 days
87.50% (168) 168 / 192 runs
flaked over last 7 days

View Detailed Build Results


@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@alannnc alannnc merged commit d52635e into main Jun 19, 2023
@alannnc alannnc deleted the fix/org-labels-typos branch June 19, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants