Skip to content

refactor: Convert card to cva#9651

Merged
keithwillcode merged 3 commits intocalcom:mainfrom
AyushMainali123:fix/convert-card-to-cva
Jun 20, 2023
Merged

refactor: Convert card to cva#9651
keithwillcode merged 3 commits intocalcom:mainfrom
AyushMainali123:fix/convert-card-to-cva

Conversation

@AyushMainali123
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR replcaces classnames with cva class.

Fixes #9301

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • Convert the card to cva without breaking any changes.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 20, 2023

@AyushMainali123 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 2:15am

@github-actions github-actions Bot added Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work labels Jun 20, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 20, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@AyushMainali123 AyushMainali123 changed the title Refactor: Convert card to cva refactor: Convert card to cva Jun 20, 2023
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Screenshot 2023-06-20 at 1 27 30 PM

@keithwillcode keithwillcode merged commit d2a12ea into calcom:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert Card component to CVA

3 participants