fix: Fix missing reschedule_reason translation#9656
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
hariombalhara
commented
Jun 20, 2023
| "kbar_search_placeholder": "Type a command or search...", | ||
| "invalid_credential": "Oh no! Looks like permission expired or was revoked. Please reinstall again.", | ||
| "reschedule_reason_success_page": "Reschedule reason", | ||
| "reschedule_reason": "Reschedule reason", |
Member
Author
There was a problem hiding this comment.
The reason behind the issue was missing reschedule_reason key
hariombalhara
changed the title
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 114 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/20/2023 08:07:07am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: b6da43e Started: 06/20/2023 08:02:54am UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
9.19% (17)17 / 185 runsfailed over last 7 days |
87.03% (161)161 / 185 runsflaked over last 7 days |
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
8.11% (15)15 / 185 runsfailed over last 7 days |
7.03% (13)13 / 185 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 2 • Retry 1 • Initial Attempt |
0.53% (1)1 / 188 runfailed over last 7 days |
12.23% (23)23 / 188 runsflaked over last 7 days |
📄 apps/web/playwright/change-password.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Change Password Test change password
Retry 1 • Initial Attempt |
0% (0)0 / 303 runsfailed over last 7 days |
1.98% (6)6 / 303 runsflaked over last 7 days |
📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
0.67% (2)2 / 297 runsfailed over last 7 days |
13.80% (41)41 / 297 runsflaked over last 7 days |
CarinaWolli
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Initially reported here https://threads.com/34482419960?s=g5bJ7c7Qc1URWWSNw5tnP1
fixes #9653
Type of change
How should this be tested?
Mandatory Tasks
Checklist