fix: Hotfix/ Dynamic Group Booking Links not working in new booker

[hariombalhara]

What does this PR do?

Group Booking Links are 404 in production. This is because new booker is enabled and it doesn't have correct handling for + everywhere.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How should this be tested?

• Visit /free%20pro/30.
  • Ensure that it's not 404
  • Ensure that availability is there for dates.
• Visit /free pro/30 and repeat the above tests
• Visit /free+pro/30 and repeat the tests
• Visit /free%2Bpro/30 and repeat the tests

Mandatory Tasks

• Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checkly Test

Added a checkly test for Booking Routes which tests dynamic group booking link and the check is failing currently

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 21, 2023 1:25pm
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 21, 2023 1:25pm
web-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 21, 2023 1:25pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
ui	⬜️ Ignored (Inspect)			Jun 21, 2023 1:25pm

[github-actions]

Thank you for following the naming conventions! 🙏

[deploysentinel]

Current Playwright Test Results Summary

✅ 98 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/21/2023 01:26:16pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: da0943c

Started: 06/21/2023 01:23:33pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests user -- old-booker can add multiple organizer address Retry 1 • Initial Attempt	3.27% (10) 10 / 306 runs failed over last 7 days	30.07% (92) 92 / 306 runs flaked over last 7 days

---

View Detailed Build Results

---

[github-actions]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (350 KB)
/new-booker/[user]/[type]	395.32 KB	548.22 KB	156.63% (🟡 +0.18%)
/new-booker/[user]/[type]/embed	395.36 KB	548.25 KB	156.64% (🟡 +0.18%)
/new-booker/d/[link]/[slug]	395.28 KB	548.18 KB	156.62% (🟡 +0.18%)
/new-booker/team/[slug]/[type]	395.34 KB	548.23 KB	156.64% (🟡 +0.17%)
/new-booker/team/[slug]/[type]/embed	395.37 KB	548.27 KB	156.65% (🟡 +0.17%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

[sean-brydon]

Tested locally - working nice find!