Skip to content

fix: overflow + zindex of cal icon#9707

Merged
PeerRich merged 4 commits intomainfrom
bug/booker-zindex-overflow
Jun 22, 2023
Merged

fix: overflow + zindex of cal icon#9707
PeerRich merged 4 commits intomainfrom
bug/booker-zindex-overflow

Conversation

@sean-brydon
Copy link
Copy Markdown
Member

PR fixes larger select items content being clipped
Fixes Cal.com logo being visible over the dropdown

Before:
chrome-capture-2023-5-22

After:
CleanShot 2023-06-22 at 09 05 07@2x

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 7:55pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 7:55pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 7:55pm
web-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 7:55pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 22, 2023

Thank you for following the naming conventions! 🙏

@PeerRich PeerRich changed the title bug: Fixes overflow + zindex of cal icon fix: overflow + zindex of cal icon Jun 22, 2023
PeerRich
PeerRich previously approved these changes Jun 22, 2023
@PeerRich PeerRich enabled auto-merge (squash) June 22, 2023 08:11
hariombalhara
hariombalhara previously approved these changes Jun 22, 2023
@sean-brydon sean-brydon dismissed stale reviews from hariombalhara and PeerRich via 2218c66 June 22, 2023 08:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 22, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jun 22, 2023

Current Playwright Test Results Summary

✅ 98 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/22/2023 07:46:06pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 980f87a

Started: 06/22/2023 07:44:06pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule for booking with seats -- old-booker If rescheduled/cancelled booking with seats it should display the correct number of seats
Retry 1Initial Attempt
2.67% (9) 9 / 337 runs
failed over last 7 days
0.89% (3) 3 / 337 runs
flaked over last 7 days

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Types Page open Embed Dialog and choose element-click for First Event Type
Retry 1Initial Attempt
0% (0) 0 / 328 runs
failed over last 7 days
1.22% (4) 4 / 328 runs
flaked over last 7 days

View Detailed Build Results


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants