chore: small changes to dropdown & main sidebar#9719
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 |
ciaranha
added
the
🧹 Improvements
sean-brydon
left a comment
sean-brydon
left a comment
There was a problem hiding this comment.
LGTM - Glad us setting up your env didnt take hours <3
| )}> | ||
| <Avatar | ||
| size={small ? "xs" : "sm"} | ||
| size={small ? "xs" : "xsm"} |
There was a problem hiding this comment.
Yea I want the avatar to be 20x20px - so if that's indeed what this does - then yes!
sean-brydon
left a comment
sean-brydon
left a comment
There was a problem hiding this comment.
Requesting changes while we figure something out
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
PeerRich
changed the title
figured out? cause i tested everytrhing and it looks fine |
Yeah all good - We spotted something with nav items but i dont think its coming from this PR - if it is i'll follow up tomorrow |
Current Playwright Test Results Summary✅ 101 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/02/2023 10:12:14am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 4537122 Started: 07/02/2023 10:10:39am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
pro user -- new-booker can book an event that requires confirmation and then that booking can be accepted by organizer
Retry 1 • Initial Attempt |
0.49% (1)1 / 205 runfailed over last 7 days |
3.90% (8)8 / 205 runsflaked over last 7 days |
📄 apps/web/playwright/booking-seats.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule for booking with seats -- old-booker Should book with seats and hide attendees info from showAttendees true
Retry 1 • Initial Attempt |
0% (0)0 / 206 runsfailed over last 7 days |
0.97% (2)2 / 206 runsflaked over last 7 days |
4 participants
What does this PR do?
Small changes to filter dropdown. Improved border colors, font-weights, focus state, icons size, spacing around dividers. Other small changes to sidebar. Making items a little more compact.
CleanShot.2023-06-22.at.16.01.31.mp4
Type of change
How should this be tested?