chore: Sync packages mismatches by zomars · Pull Request #9725 · calcom/cal.diy

zomars · 2023-06-22T18:47:38Z

What does this PR do?

Syncs mismatched module versions between packages
Adds missing packages in various packages
Fixes linting and formatting issues where previously were not erroring
Fixes type checks that were not being checked

Type of change

Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

yarn
yarn build
yarn e2e

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

vercel · 2023-06-22T18:47:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 22, 2023 8:36pm
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 22, 2023 8:36pm
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 22, 2023 8:36pm
web-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 22, 2023 8:36pm

github-actions · 2023-06-22T18:47:50Z

Thank you for following the naming conventions! 🙏

socket-security · 2023-06-22T18:56:53Z

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages		Version	New capabilities	Transitives¹	Size	Publisher
@radix-ui/react-dropdown-menu	⬆️	1.0.0...2.0.5	None	`+2/-56`	819 kB	benoitgrelard
next-axiom	⬆️	0.16.0...0.17.0	None	`+0/-0`	370 kB	lukasmalkmus
next-seo	⬆️	4.29.0...6.1.0	None	`+0/-0`	464 kB	garymeehan
next-i18next	⬆️	11.3.0...13.3.0	environment	`+6/-9`	3.76 MB	adrai

🚮 Removed packages: @types/react-dom@18.0.9, @vercel/og@0.0.21, @vitejs/plugin-react@1.3.2

https://docs.socket.dev ↩

github-actions · 2023-06-22T19:47:26Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Fifty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/apps`	`295 KB`	447.97 KB	127.99% (🟡 +4.61%)
`/apps/[slug]`	`312.98 KB`	465.95 KB	133.13% (🟡 +4.61%)
`/apps/[slug]/[...pages]`	`436.2 KB`	589.17 KB	168.33% (🟡 +4.10%)
`/apps/categories`	`257.76 KB`	410.73 KB	117.35% (🟡 +4.61%)
`/apps/categories/[category]`	`278.24 KB`	431.21 KB	123.20% (🟡 +4.62%)
`/apps/installed/[category]`	`294.53 KB`	447.5 KB	127.86% (🟡 +4.61%)
`/availability`	`263.08 KB`	416.05 KB	118.87% (🟡 +4.61%)
`/availability/[schedule]`	`349.23 KB`	502.2 KB	143.49% (🟡 +4.61%)
`/availability/troubleshoot`	`258.49 KB`	411.46 KB	117.56% (🟡 +4.61%)
`/bookings/[status]`	`350.92 KB`	503.89 KB	143.97% (🟡 +4.09%)
`/event-types`	`444.79 KB`	597.76 KB	170.79% (🟡 +4.09%)
`/event-types/[type]`	`495.05 KB`	648.02 KB	185.15% (🟡 +4.09%)
`/getting-started/[[...step]]`	`439.9 KB`	592.87 KB	169.39% (🟡 +4.16%)
`/insights`	`464.92 KB`	617.89 KB	176.54% (🟡 +4.61%)
`/more`	`257.39 KB`	410.36 KB	117.24% (🟡 +4.62%)
`/settings/admin`	`263.21 KB`	416.19 KB	118.91% (🟡 +4.61%)
`/settings/admin/apps`	`274.97 KB`	427.95 KB	122.27% (🟡 +4.61%)
`/settings/admin/apps/[category]`	`274.96 KB`	427.93 KB	122.27% (🟡 +4.61%)
`/settings/admin/flags`	`266.01 KB`	418.98 KB	119.71% (🟡 +4.61%)
`/settings/admin/impersonation`	`263.5 KB`	416.47 KB	118.99% (🟡 +4.61%)
`/settings/admin/users`	`264.63 KB`	417.6 KB	119.32% (🟡 +4.61%)
`/settings/admin/users/[id]/edit`	`351.02 KB`	503.99 KB	144.00% (🟡 +4.61%)
`/settings/admin/users/add`	`350.7 KB`	503.67 KB	143.91% (🟡 +4.61%)
`/settings/billing`	`263.37 KB`	416.34 KB	118.96% (🟡 +4.61%)
`/settings/developer/api-keys`	`291.92 KB`	444.89 KB	127.11% (🟡 +4.62%)
`/settings/developer/webhooks`	`266.36 KB`	419.33 KB	119.81% (🟡 +4.61%)
`/settings/developer/webhooks/[id]`	`268.11 KB`	421.08 KB	120.31% (🟡 +4.61%)
`/settings/developer/webhooks/new`	`267.97 KB`	420.94 KB	120.27% (🟡 +4.61%)
`/settings/my-account/appearance`	`284.53 KB`	437.5 KB	125.00% (🟡 +4.10%)
`/settings/my-account/calendars`	`269.84 KB`	422.82 KB	120.80% (🟡 +4.62%)
`/settings/my-account/conferencing`	`268.99 KB`	421.96 KB	120.56% (🟡 +4.62%)
`/settings/my-account/general`	`348.22 KB`	501.19 KB	143.20% (🟡 +4.61%)
`/settings/my-account/profile`	`390.71 KB`	543.68 KB	155.34% (🟡 +4.61%)
`/settings/organizations/appearance`	`275.93 KB`	428.91 KB	122.54% (🟡 +4.10%)
`/settings/organizations/general`	`343.83 KB`	496.8 KB	141.94% (🟡 +4.62%)
`/settings/organizations/members`	`380.64 KB`	533.61 KB	152.46% (🟡 +4.59%)
`/settings/organizations/profile`	`385.83 KB`	538.8 KB	153.94% (🟡 +4.62%)
`/settings/security/impersonation`	`265.17 KB`	418.14 KB	119.47% (🟡 +4.61%)
`/settings/security/password`	`274.64 KB`	427.62 KB	122.18% (🟡 +4.61%)
`/settings/security/sso`	`272.65 KB`	425.62 KB	121.61% (🟡 +4.61%)
`/settings/security/two-factor-auth`	`267.61 KB`	420.58 KB	120.17% (🟡 +4.61%)
`/settings/teams`	`262.98 KB`	415.95 KB	118.84% (🟡 +4.62%)
`/settings/teams/[id]/appearance`	`275.94 KB`	428.91 KB	122.55% (🟡 +4.09%)
`/settings/teams/[id]/billing`	`263.22 KB`	416.2 KB	118.91% (🟡 +4.62%)
`/settings/teams/[id]/members`	`382.92 KB`	535.89 KB	153.11% (🟡 +4.59%)
`/settings/teams/[id]/profile`	`453.43 KB`	606.4 KB	173.26% (🟡 +4.61%)
`/settings/teams/[id]/sso`	`272.75 KB`	425.72 KB	121.63% (🟡 +4.62%)
`/settings/teams/new`	`202.65 KB`	355.62 KB	101.61% (🟡 +4.59%)
`/teams`	`257.48 KB`	410.45 KB	117.27% (🟡 +4.62%)
`/workflows`	`268.47 KB`	421.44 KB	120.41% (🟡 +4.10%)
`/workflows/[workflow]`	`384.48 KB`	537.45 KB	153.56% (🟡 +4.61%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

deploysentinel · 2023-06-22T19:49:03Z

Current Playwright Test Results Summary

✅ 114 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/22/2023 10:19:21pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: f7d97e8

Started: 06/22/2023 10:17:09pm UTC

⚠️ Flakes

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	21.98% (51) 51 / 232 runs failed over last 7 days	74.57% (173) 173 / 232 runs flaked over last 7 days

📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download Retry 1 • Initial Attempt	2.67% (6) 6 / 225 runs failed over last 7 days	21.33% (48) 48 / 225 runs flaked over last 7 days

📄 apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
pro user -- new-booker can reschedule a booking Retry 1 • Initial Attempt	0.86% (3) 3 / 350 runs failed over last 7 days	3.14% (11) 11 / 350 runs flaked over last 7 days

📄 apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking with Seats -- new-booker Attendees can cancel a seated event time slot Retry 1 • Initial Attempt	0.57% (2) 2 / 351 runs failed over last 7 days	5.13% (18) 18 / 351 runs flaked over last 7 days

View Detailed Build Results

alannnc

Everything looks good!

emrysal

good to go

hybes · 2023-06-23T08:22:29Z

@zomars getting build errors with @calcom/web:build now:

@calcom/web:build: Duplicate value found in:  org_upgrade_banner_action
@calcom/web:build: Duplicate value found in:  all
@calcom/web:build: Duplicate value found in:  layout
@calcom/web:build: Duplicate value found in:  count_members_one
@calcom/web:build: Duplicate value found in:  count_members_other
@calcom/web:build: Duplicate value found in:  learn_more
@calcom/web:build: Duplicate value found in:  get_in_touch
@calcom/web:build: Duplicate value found in:  organization_url_taken
@calcom/web:build: Duplicate value found in:  org_name
@calcom/web:build: Duplicate value found in:  org_url
@calcom/web:build: Enabling New Booker for Non-Embed
@calcom/web:build: - info Linting and checking validity of types...
@calcom/web:build: 
@calcom/web:build: Failed to compile.
@calcom/web:build: 
@calcom/web:build: ./pages/api/email.ts
@calcom/web:build: 11:9  Warning: 'evt' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 
@calcom/web:build: ./pages/booking/[uid].tsx
@calcom/web:build: 683:33  Warning: 'target' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 
@calcom/web:build: ./pages/event-types/[type]/index.tsx
@calcom/web:build: 340:7  Warning: 'bookerLayouts' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 371:13  Warning: 'availability' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 453:21  Warning: 'availability' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 
@calcom/web:build: ./pages/event-types/index.tsx
@calcom/web:build: 731:40  Error: Replace `me-2·ms-2·relative·-top-px` with `relative·-top-px·me-2·ms-2`  prettier/prettier
@calcom/web:build: 
@calcom/web:build: ./pages/settings/my-account/appearance.tsx
@calcom/web:build: 58:47  Warning: 'hasPaidPlan' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
@calcom/web:build: 
@calcom/web:build: ./components/team/screens/Team.tsx
@calcom/web:build: 33:29  Error: Replace `line-clamp-4·mt-2` with `mt-2·line-clamp-4`  prettier/prettier
@calcom/web:build: 
@calcom/web:build: info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
@calcom/web:build: ERROR: command finished with error: command (/Users/admin/Documents/calcom/apps/web) yarn run build exited (1)
command (/Users/admin/Documents/calcom/apps/web) yarn run build exited (1)

 Tasks:    5 successful, 6 total
Cached:    0 cached, 6 total
  Time:    40.701s 
Failed:    @calcom/web#build```

hybes · 2023-06-23T08:48:06Z

also realised, it's wrong about the tailwind order anyway?

Sync packages

87712e3

vercel Bot had a problem deploying to Preview – ui June 22, 2023 18:50 Failure

vercel Bot had a problem deploying to Preview – cal June 22, 2023 18:50 Failure

vercel Bot had a problem deploying to Preview – api June 22, 2023 18:50 Failure

vercel Bot had a problem deploying to Preview – web-staging June 22, 2023 18:52 Failure

WIP

8c4d2e7

vercel Bot deployed to Preview – ui June 22, 2023 19:38 View deployment

Update error.tsx

5ce0cae

vercel Bot deployed to Preview – cal June 22, 2023 19:45 View deployment

vercel Bot deployed to Preview – api June 22, 2023 19:45 View deployment

Update Credits.tsx

f7d97e8

zomars requested review from a team June 22, 2023 19:49

zomars added 2 commits June 22, 2023 12:50

Merge branch 'main' into chore/sync-package-mistmaches

c85fecb

formatting

6e89dd8

vercel Bot deployed to Preview – ui June 22, 2023 19:57 View deployment

vercel Bot deployed to Preview – cal June 22, 2023 19:59 View deployment

vercel Bot deployed to Preview – api June 22, 2023 20:01 View deployment

vercel Bot deployed to Preview – web-staging June 22, 2023 20:36 View deployment

alannnc approved these changes Jun 22, 2023

View reviewed changes

emrysal approved these changes Jun 22, 2023

View reviewed changes

zomars merged commit 2d6eebc into main Jun 22, 2023

zomars deleted the chore/sync-package-mistmaches branch June 22, 2023 22:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Sync packages mismatches#9725

chore: Sync packages mismatches#9725
zomars merged 6 commits intomainfrom
chore/sync-package-mistmaches

zomars commented Jun 22, 2023 •

edited

Loading

Uh oh!

vercel Bot commented Jun 22, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 22, 2023 •

edited

Loading

Uh oh!

socket-security Bot commented Jun 22, 2023

Uh oh!

github-actions Bot commented Jun 22, 2023 •

edited

Loading

Uh oh!

deploysentinel Bot commented Jun 22, 2023 •

edited

Loading

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Uh oh!

alannnc left a comment

Uh oh!

emrysal left a comment

Uh oh!

hybes commented Jun 23, 2023 •

edited

Loading

Uh oh!

hybes commented Jun 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

zomars commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Mandatory Tasks

Uh oh!

vercel Bot commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security Bot commented Jun 22, 2023

Footnotes

Uh oh!

github-actions Bot commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Fifty-one Pages Changed Size

Uh oh!

deploysentinel Bot commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Uh oh!

alannnc left a comment

Choose a reason for hiding this comment

Uh oh!

emrysal left a comment

Choose a reason for hiding this comment

Uh oh!

hybes commented Jun 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hybes commented Jun 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zomars commented Jun 22, 2023 •

edited

Loading

vercel Bot commented Jun 22, 2023 •

edited

Loading

github-actions Bot commented Jun 22, 2023 •

edited

Loading

github-actions Bot commented Jun 22, 2023 •

edited

Loading

deploysentinel Bot commented Jun 22, 2023 •

edited

Loading

hybes commented Jun 23, 2023 •

edited

Loading