Skip to content

fix: Public Link of pending members is now disabled#9730

Merged
PeerRich merged 3 commits intocalcom:mainfrom
AnitKrJha:9701_Public_page
Jun 23, 2023
Merged

fix: Public Link of pending members is now disabled#9730
PeerRich merged 3 commits intocalcom:mainfrom
AnitKrJha:9701_Public_page

Conversation

@AnitKrJha
Copy link
Copy Markdown
Contributor

What does this PR do?

Public pages' button for pending members of a team is now disabled.

Fixes #9701

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 22, 2023

@AnitKrJha is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 8:34am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 22, 2023

Thank you for following the naming conventions! 🙏

@github-actions github-actions Bot added organizations area: organizations, orgs 🐛 bug Something isn't working labels Jun 22, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 22, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@AnitKrJha
Copy link
Copy Markdown
Contributor Author

AnitKrJha commented Jun 22, 2023

@PeerRich @hariombalhara

I would like to request your review of the recent changes I made.

Additionally, while going through the codebase,
I noticed an issue with the implementation of the DropdownItem component.

It seems that when the href prop is passed to the DropdownItem component, the disabled prop does not properly disable the button. Upon further examination, I discovered that the type of element is determined based on whether a link has been passed or not. When a link is provided, the underlying element becomes an a HTML element. Consequently, the disabled prop has no effect as the a element does not have a disabled property.

I'm not sure if this implementation was intentional or if it requires attention and adjustment.

I wanted to bring this to your attention and kindly ask you to look into it.

@PeerRich PeerRich merged commit 0eb05aa into calcom:main Jun 23, 2023
@AnitKrJha AnitKrJha deleted the 9701_Public_page branch June 23, 2023 09:41
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working organizations area: organizations, orgs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Public pages button are enabled for pending users

2 participants