fix: Various errors & 500 error on duplicate url when editing#9731
Merged
keithwillcode merged 1 commit intomainfrom Jun 23, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 114 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/22/2023 10:59:58pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 7b32b77 Started: 06/22/2023 10:57:49pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 2 • Retry 1 • Initial Attempt |
2.64% (6)6 / 227 runsfailed over last 7 days |
22.03% (50)50 / 227 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- new-booker can add multiple organizer address
Retry 1 • Initial Attempt |
0.29% (1)1 / 348 runfailed over last 7 days |
19.25% (67)67 / 348 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
21.79% (51)51 / 234 runsfailed over last 7 days |
74.79% (175)175 / 234 runsflaked over last 7 days |
keithwillcode
approved these changes
Jun 23, 2023
Contributor
keithwillcode
left a comment
keithwillcode
left a comment
There was a problem hiding this comment.
Looks good. Tested saving all sorts of event type changes and tested changing slugs to already-existing event type slug. No more 500s. Error shown to the user saying it would be a duplicate.
keithwillcode
deleted the
bugfix/fix-500-error-on-event-type-duplicate-url
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes 500 error in logs, return human readable error; as well as various other translation related error messages.