Skip to content

fix: Event Analytics Apps not working with new booker#9740

Merged
kodiakhq[bot] merged 1 commit intomainfrom
hariom/cal-2036-event-analytics-not-working-with-new-booker
Jun 23, 2023
Merged

fix: Event Analytics Apps not working with new booker#9740
kodiakhq[bot] merged 1 commit intomainfrom
hariom/cal-2036-event-analytics-not-working-with-new-booker

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Jun 23, 2023

What does this PR do?

Adds back Event Analytics to new booker.

Fixes #9738

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Install GA/GTM/Fathom/Plausible and see that the call is going from booker.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@linear
Copy link
Copy Markdown

linear Bot commented Jun 23, 2023

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 8:37am
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 8:37am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 8:37am
web-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 8:37am

@github-actions github-actions Bot added High priority Created by Linear-GitHub Sync Urgent Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Jun 23, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 23, 2023

Thank you for following the naming conventions! 🙏

@hariombalhara hariombalhara removed the 🐛 bug Something isn't working label Jun 23, 2023
@hariombalhara hariombalhara changed the title Event Analytics not working for new booker fix: event Analytics not working for new booker Jun 23, 2023
@hariombalhara hariombalhara changed the title fix: event Analytics not working for new booker fix: Event Analytics Apss not working with new booker Jun 23, 2023
@hariombalhara hariombalhara changed the title fix: Event Analytics Apss not working with new booker fix: Event Analytics Apps not working with new booker Jun 23, 2023
@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/payment/[uid] 109.77 KB 262.74 KB 75.07% (🟢 -3.26%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jun 23, 2023

Current Playwright Test Results Summary

✅ 98 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/23/2023 08:41:21am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 0fd4cd7

Started: 06/23/2023 08:39:32am UTC

⚠️ Flakes

📄   apps/web/playwright/change-theme.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Change Theme Test change theme to dark
Retry 1Initial Attempt
0% (0) 0 / 313 runs
failed over last 7 days
1.60% (5) 5 / 313 runs
flaked over last 7 days

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 1Initial Attempt
2.20% (7) 7 / 318 runs
failed over last 7 days
18.87% (60) 60 / 318 runs
flaked over last 7 days

View Detailed Build Results


@kodiakhq kodiakhq Bot merged commit 49bcd5f into main Jun 23, 2023
@kodiakhq kodiakhq Bot deleted the hariom/cal-2036-event-analytics-not-working-with-new-booker branch June 23, 2023 08:42
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge core area: core, team members only High priority Created by Linear-GitHub Sync Urgent Created by Linear-GitHub Sync

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

[CAL-2036] Event Analytics not working with New Booker

3 participants