Skip to content

fix: api date picker to drop down#9810

Merged
sean-brydon merged 5 commits into
calcom:mainfrom
AnitKrJha:fix/api-date-picker
Jun 29, 2023
Merged

fix: api date picker to drop down#9810
sean-brydon merged 5 commits into
calcom:mainfrom
AnitKrJha:fix/api-date-picker

Conversation

@AnitKrJha
Copy link
Copy Markdown
Contributor

@AnitKrJha AnitKrJha commented Jun 26, 2023 •
edited
Loading

What does this PR do?

Changes the date-picker to a 4 option dropdown for setting expiration date of api_key

Fixes #9760

Before

image

After

Recording.2023-06-27.041534.mp4

/claim #9760

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api 🔄 Building (Inspect) Jun 29, 2023 8:26am
cal 🔄 Building (Inspect) Jun 29, 2023 8:26am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 8:26am
web-staging 🔄 Building (Inspect) Jun 29, 2023 8:26am

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 26, 2023

@AnitKrJha is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input 🐛 bug Something isn't working 💎 Bounty A bounty on Algora.io labels Jun 26, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 26, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏

@algora-pbc algora-pbc Bot mentioned this pull request Jun 26, 2023
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 26, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Fifty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 283.02 KB 436.15 KB 124.61% (🟢 -0.32%)
/apps/[slug] 301.02 KB 454.14 KB 129.76% (🟢 -0.33%)
/apps/[slug]/[...pages] 437.27 KB 590.4 KB 168.68% (🟢 -0.37%)
/apps/categories 263 KB 416.12 KB 118.89% (🟢 -0.32%)
/apps/categories/[category] 266.26 KB 419.39 KB 119.83% (🟢 -0.33%)
/apps/installed/[category] 282.85 KB 435.98 KB 124.56% (🟢 -0.14%)
/availability 268.53 KB 421.65 KB 120.47% (🟢 -0.32%)
/availability/[schedule] 354.47 KB 507.6 KB 145.03% (🟢 -0.32%)
/availability/troubleshoot 263.73 KB 416.86 KB 119.10% (🟢 -0.32%)
/bookings/[status] 351.24 KB 504.37 KB 144.11% (🟢 -0.34%)
/event-types 444.64 KB 597.76 KB 170.79% (🟢 -0.48%)
/event-types/[type] 495.85 KB 648.97 KB 185.42% (🔴 +57.05%)
/getting-started/[[...step]] 420.89 KB 574.01 KB 164.00% (🟡 +0.23%)
/insights 470.17 KB 623.29 KB 178.08% (🟢 -0.32%)
/more 262.63 KB 415.75 KB 118.79% (🟢 -0.33%)
/settings/admin 268.46 KB 421.58 KB 120.45% (🟢 -0.32%)
/settings/admin/apps 278.86 KB 431.99 KB 123.42% (🟢 -0.35%)
/settings/admin/apps/[category] 278.85 KB 431.97 KB 123.42% (🟢 -0.34%)
/settings/admin/flags 271.25 KB 424.37 KB 121.25% (🟢 -0.33%)
/settings/admin/impersonation 268.74 KB 421.86 KB 120.53% (🟢 -0.32%)
/settings/admin/users 269.87 KB 423 KB 120.86% (🟢 -0.33%)
/settings/admin/users/[id]/edit 350.03 KB 503.16 KB 143.76% (🟢 -0.33%)
/settings/admin/users/add 349.71 KB 502.84 KB 143.67% (🟢 -0.33%)
/settings/billing 268.61 KB 421.74 KB 120.50% (🟢 -0.33%)
/settings/developer/api-keys 272.4 KB 425.53 KB 121.58% (🟢 -7.41%)
/settings/developer/webhooks 271.91 KB 425.03 KB 121.44% (🟢 -0.33%)
/settings/developer/webhooks/[id] 273.35 KB 426.48 KB 121.85% (🟢 -0.31%)
/settings/developer/webhooks/new 273.21 KB 426.34 KB 121.81% (🟢 -0.31%)
/settings/my-account/appearance 283.82 KB 436.94 KB 124.84% (🟢 -0.31%)
/settings/my-account/conferencing 274.33 KB 427.45 KB 122.13% (🟢 -0.34%)
/settings/my-account/general 353.46 KB 506.58 KB 144.74% (🟢 -0.33%)
/settings/my-account/profile 396.54 KB 549.67 KB 157.05% (🟢 -0.33%)
/settings/organizations/appearance 281.17 KB 434.3 KB 124.09% (🟢 -0.26%)
/settings/organizations/general 349.06 KB 502.19 KB 143.48% (🟢 -0.32%)
/settings/organizations/members 380.4 KB 533.52 KB 152.44% (🟢 -0.33%)
/settings/organizations/profile 391.07 KB 544.2 KB 155.49% (🟢 -0.33%)
/settings/security/impersonation 270.41 KB 423.54 KB 121.01% (🟢 -0.32%)
/settings/security/password 273.62 KB 426.75 KB 121.93% (🟢 -0.33%)
/settings/security/sso 277.89 KB 431.01 KB 123.15% (🟢 -0.33%)
/settings/security/two-factor-auth 272.83 KB 425.96 KB 121.70% (🟢 -0.33%)
/settings/teams 268.22 KB 421.35 KB 120.39% (🟢 -0.33%)
/settings/teams/[id]/appearance 281.18 KB 434.3 KB 124.09% (🟢 -0.26%)
/settings/teams/[id]/billing 268.46 KB 421.59 KB 120.45% (🟢 -0.32%)
/settings/teams/[id]/members 382.68 KB 535.8 KB 153.09% (🟢 -0.33%)
/settings/teams/[id]/onboard-members 176.92 KB 330.04 KB 94.30% (🟢 -0.26%)
/settings/teams/[id]/profile 459.97 KB 613.1 KB 175.17% (🟢 -0.18%)
/settings/teams/[id]/sso 277.98 KB 431.11 KB 123.17% (🟢 -0.33%)
/settings/teams/new 216.29 KB 369.41 KB 105.55% (🟢 -0.34%)
/teams 262.72 KB 415.84 KB 118.81% (🟢 -0.32%)
/workflows 275.02 KB 428.14 KB 122.33% (🟢 -0.33%)
/workflows/[workflow] 383.87 KB 536.99 KB 153.43% (🟢 -0.45%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

AnitKrJha
AnitKrJha commented Jun 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@AnitKrJha AnitKrJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel good to go with

@AnitKrJha
Copy link
Copy Markdown
Contributor Author

AnitKrJha commented Jun 26, 2023

@PeerRich please review the changes asap!

jhb-dev
jhb-dev reviewed Jun 27, 2023
View reviewed changes
Comment thread packages/features/ee/api-keys/components/ApiKeyDialogForm.tsx Outdated
@PeerRich PeerRich requested a review from CarinaWolli June 27, 2023 16:16
@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Jun 27, 2023

looks good so far! @CarinaWolli can give a final say

@PeerRich PeerRich requested a review from a team June 27, 2023 16:16
@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Jun 27, 2023

or actually maybe @sean-brydon

sean-brydon
sean-brydon reviewed Jun 29, 2023
View reviewed changes
Comment thread packages/features/ee/api-keys/components/ApiKeyDialogForm.tsx Outdated
sean-brydon
sean-brydon previously approved these changes Jun 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2023-06-29 at 09.20.52@2x.png

Can't fault seems to work well!

@sean-brydon sean-brydon enabled auto-merge (squash) June 29, 2023 08:22
@sean-brydon sean-brydon merged commit f1aed2d into calcom:main Jun 29, 2023
@AnitKrJha AnitKrJha deleted the fix/api-date-picker branch July 2, 2023 13:57
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
@AnitKrJha @PeerRich
@sean-brydon @fritterhoff
fix: api date picker to drop down (calcom#9810)
963e913 
* fix: api date picker to drop down

* fix: api key , date picker to drop down

* Update packages/features/ee/api-keys/components/ApiKeyDialogForm.tsx

---------

Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sean-brydon sean-brydon sean-brydon approved these changes

@CarinaWolli CarinaWolli Awaiting requested review from CarinaWolli

+1 more reviewer

@jhb-dev jhb-dev jhb-dev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

💎 Bounty A bounty on Algora.io 🐛 bug Something isn't working Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API key expiration time calender is out of theme, text is not visible dark mode

4 participants

@AnitKrJha @PeerRich @jhb-dev @sean-brydon