fix: phone number disappearing issue#9811
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@anmol242 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
Medium priority
Contributor
|
Thank you for following the naming conventions! 🙏 |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
anmol242
force-pushed
the
fix/pre-fill-phone-number
branch
from
ac67894 to
6d4a425
Compare
anmol242
commented
Jun 27, 2023
anmol242
force-pushed
the
fix/pre-fill-phone-number
branch
from
6d4a425 to
24b2430
Compare
anmol242
commented
Jun 27, 2023
| <PhoneInput | ||
| {...rest} | ||
| country={defaultCountry} | ||
| country={rest.value && countryCode ? undefined : defaultCountry} |
Contributor
Author
There was a problem hiding this comment.
Have to done this change to see its an valid country code in phone number other wise it was changing to US
anmol242
commented
Jun 27, 2023
anmol242
force-pushed
the
fix/pre-fill-phone-number
branch
2 times, most recently
from
6eebba6 to
06850b2
Compare
PeerRich
added
event-types
Udit-takkar
reviewed
Jun 28, 2023
anmol242
force-pushed
the
fix/pre-fill-phone-number
branch
from
06850b2 to
f89ff81
Compare
Contributor
Author
|
@PeerRich or anyone from the team can I get a re-review on this PR? |
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Udit-takkar
approved these changes
Jul 1, 2023
Contributor
Udit-takkar
left a comment
Udit-takkar
left a comment
There was a problem hiding this comment.
LGTM.
Screen.Recording.2023-07-01.at.4.44.06.PM.mov
Contributor
Author
|
@CarinaWolli or anyone from team can we merge this? |
fritterhoff
pushed a commit
to hm-edu/cal.com
that referenced
this pull request
Jul 25, 2023
Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the pre-fill issue for Phone number field while booking event or rescheduling event
Fixes #9682
Before Fix
https://www.loom.com/share/a6024364e1c744bf9db82e4b62504514?sid=8bb91e81-8055-474a-948e-ae7bc07520ff
After Fix
https://www.loom.com/share/6ee121cf728d4769a915d7ce2172795e?sid=72a86bcb-84cf-41d3-9ef5-e7303a21358a
Type of change
How should this be tested?
Identifierasphoneor whatever you want to fillMandatory Tasks