Skip to content

fix: title-for-team-events#9828

Merged
CarinaWolli merged 1 commit into
calcom:mainfrom
ujwalkumar1995:fix-title-team-events
Jun 28, 2023
Merged

fix: title-for-team-events#9828
CarinaWolli merged 1 commit into
calcom:mainfrom
ujwalkumar1995:fix-title-team-events

Conversation

@ujwalkumar1995
Copy link
Copy Markdown
Contributor

@ujwalkumar1995 ujwalkumar1995 commented Jun 27, 2023

What does this PR do?

This PR fixes the missing title in team events.

Fixes #9724
Fixes #9824

Recording.2023-06-28.000531.mp4

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Try to book a team event. Title should be properly displayed.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api 🔄 Building (Inspect) Jun 27, 2023 6:44pm
cal 🔄 Building (Inspect) Jun 27, 2023 6:44pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 6:44pm

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 27, 2023

@ujwalkumar1995 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 27, 2023

Thank you for following the naming conventions! 🙏

@ujwalkumar1995
Copy link
Copy Markdown
Contributor Author

I am unable to see the screenshots on the issue #9824 but based on the issue description it might be same issue. So this PR may be fixes that as well.

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@PeerRich PeerRich requested a review from CarinaWolli June 28, 2023 12:44
Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👏🏻 Thank you for your contribution :)

@CarinaWolli CarinaWolli merged commit 6a97519 into calcom:main Jun 28, 2023
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-2060] Tab title is missing data [CAL-2030] team events have a broken <title>

2 participants