Skip to content

fix: Fix additional skeleton issues#9839

Merged
PeerRich merged 3 commits into
mainfrom
additional-skeleton-issues
Jun 28, 2023
Merged

fix: Fix additional skeleton issues#9839
PeerRich merged 3 commits into
mainfrom
additional-skeleton-issues

Conversation

@gitstart-calcom
Copy link
Copy Markdown
Contributor

@gitstart-calcom gitstart-calcom commented Jun 28, 2023

Here is the GitStart Ticket for this pull request: additional-skeleton-issues

  • Please mark your PR as "ready for review" when you have completed all requirements.
  • Please ensure that your PR is reviewed by at least 2 people after you have completed it.
  • Comments for review or requested changes from the upstream client will be notified to you by email and will also show on the ticket page.
  • After the PR is merged on the upstream, please merge this PR.
  • If there exist merge conflicts on your current PR and you have to close the PR instead of merging it, please go to the ticket page to manually finish the task that is related to this PR.

Happy hacking! 🎉

Demo

Availabilty Page
Before:

248849317-6160ddd2-d117-43a8-b89a-a5b3e945c653.1.mov

After:

  • adjust 'set to default' skeleton
  • adjust 'Timezone' text skeleton
  • adjust 'Something doesn't look right' skeleton
  • adjust 'Launch troubleshooter' skeleton
248849395-0694f1a4-db09-4962-bc12-97c0ea6cdc4b.1.mov

Teams Page:

Before:

248928122-a5252336-f74c-41fc-b093-809afaf04a34.1.mov
248928153-372dd852-7432-49fa-abb5-23e089fbad19.1.mov

After:

  • fix title and description loader on 'Create new team' page
  • fix title and description loader on 'Add new team member' page
248942109-4adb6105-820d-4f06-993a-839d7821539f.mov
248942411-c6871878-bfe2-46e1-9b1b-0300d4c0cdfc.1.mov

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 8:29pm
web-staging ❌ Failed (Inspect) Jun 28, 2023 8:29pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jun 28, 2023 8:29pm
ui ⬜️ Ignored (Inspect) Visit Preview Jun 28, 2023 8:29pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 28, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 28, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@gitstart-calcom gitstart-calcom marked this pull request as ready for review June 28, 2023 19:19
Comment thread apps/web/pages/availability/[schedule].tsx Outdated
Comment thread apps/web/pages/availability/[schedule].tsx Outdated
@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jun 28, 2023

Current Playwright Test Results Summary

✅ 120 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/28/2023 08:34:12pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: cf55340

Started: 06/28/2023 08:32:17pm UTC

⚠️ Flakes

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 1Initial Attempt
2.89% (8) 8 / 277 runs
failed over last 7 days
10.11% (28) 28 / 277 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1Initial Attempt
7.18% (13) 13 / 181 runs
failed over last 7 days
37.57% (68) 68 / 181 runs
flaked over last 7 days

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
1.41% (4) 4 / 283 runs
failed over last 7 days
9.19% (26) 26 / 283 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich PeerRich merged commit 5059723 into main Jun 28, 2023
@PeerRich PeerRich deleted the additional-skeleton-issues branch June 28, 2023 22:09
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com>
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants