fix: Legacy Routing Forms handling - Allow team Event in existing non-team Routing forms#9852
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 108 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/29/2023 06:25:29pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 6a23c9d Started: 06/29/2023 06:12:39pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule Tests -- old-booker Attendee should be able to reschedule a booking
Retry 1 • Initial Attempt |
0% (0)0 / 246 runsfailed over last 7 days |
18.70% (46)46 / 246 runsflaked over last 7 days |
hariombalhara
commented
Jun 29, 2023
| const uniqueSlug = `${group.profile.slug}/${eventType.slug}`; | ||
| const isLegacy = isRouter(route) ? false : uniqueSlug === route.action.value; | ||
|
|
||
| if (!isLegacy && !eventTypeValidInContext) { |
Member
Author
There was a problem hiding this comment.
If it's a legacy case where an existing team event might be selected, let that team event pass through.
hariombalhara
force-pushed
the
fix/allow-team-event-in-legacy-routing-form
branch
from
7450bf3 to
47590bd
Compare
hariombalhara
changed the title
fritterhoff
pushed a commit
to hm-edu/cal.com
that referenced
this pull request
Jul 25, 2023
…-team Routing forms (calcom#9852)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #9853
Allow an existing User Routing Form to link to a Team EventType if it's already selected.
Type of change
How should this be tested?
Mandatory Tasks
Checklist