Skip to content

fix: message for mandatory name field on profile#9861

Merged
CarinaWolli merged 2 commits into
calcom:mainfrom
ujwalkumar1995:fix-message-for-name-on-profile
Jun 30, 2023
Merged

fix: message for mandatory name field on profile#9861
CarinaWolli merged 2 commits into
calcom:mainfrom
ujwalkumar1995:fix-message-for-name-on-profile

Conversation

@ujwalkumar1995
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR fixes the message for mandatory name field on profile.

Fixes #9857

Screenshot 2023-06-30 203222

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Try to save your profile by completely deleting the name field. You should see a proper error message.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 3:17pm

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 30, 2023

@ujwalkumar1995 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added Low priority Created by Linear-GitHub Sync organizations area: organizations, orgs 🐛 bug Something isn't working labels Jun 30, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 30, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Fifty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 300.17 KB 453.3 KB 129.51% (🟡 +4.58%)
/apps/[slug] 318.15 KB 471.29 KB 134.65% (🟡 +4.57%)
/apps/[slug]/[...pages] 437.2 KB 590.33 KB 168.67% (🟢 -0.41%)
/apps/categories 262.92 KB 416.05 KB 118.87% (🟢 -0.34%)
/apps/categories/[category] 283.41 KB 436.54 KB 124.73% (🟡 +4.57%)
/apps/installed/[category] 299.78 KB 452.92 KB 129.40% (🟡 +4.70%)
/availability 268.45 KB 421.58 KB 120.45% (🟢 -0.34%)
/availability/[schedule] 354.4 KB 507.53 KB 145.01% (🟢 -0.35%)
/availability/troubleshoot 263.66 KB 416.79 KB 119.08% (🟢 -0.35%)
/bookings/[status] 351.17 KB 504.3 KB 144.09% (🟢 -0.36%)
/event-types 444.56 KB 597.69 KB 170.77% (🟢 -0.51%)
/event-types/[type] 495.74 KB 648.87 KB 185.39% (🔴 +57.01%)
/getting-started/[[...step]] 447.79 KB 600.92 KB 171.69% (🟡 +7.91%)
/insights 470.09 KB 623.22 KB 178.06% (🟢 -2.76%)
/more 262.55 KB 415.69 KB 118.77% (🟢 -0.35%)
/settings/admin 268.38 KB 421.51 KB 120.43% (🟢 -0.34%)
/settings/admin/apps 278.64 KB 431.77 KB 123.36% (🟢 -0.41%)
/settings/admin/apps/[category] 278.63 KB 431.76 KB 123.36% (🟢 -0.41%)
/settings/admin/flags 271.17 KB 424.3 KB 121.23% (🟢 -0.35%)
/settings/admin/impersonation 268.66 KB 421.79 KB 120.51% (🟢 -0.34%)
/settings/admin/users 269.8 KB 422.93 KB 120.84% (🟢 -0.35%)
/settings/admin/users/[id]/edit 349.96 KB 503.09 KB 143.74% (🟢 -0.35%)
/settings/admin/users/add 349.64 KB 502.77 KB 143.65% (🟢 -0.35%)
/settings/billing 268.54 KB 421.67 KB 120.48% (🟢 -0.35%)
/settings/developer/api-keys 297.09 KB 450.22 KB 128.63% (🟡 +6.73%)
/settings/developer/webhooks 271.83 KB 424.96 KB 121.42% (🟢 -0.35%)
/settings/developer/webhooks/[id] 273.28 KB 426.41 KB 121.83% (🟢 -0.33%)
/settings/developer/webhooks/new 273.14 KB 426.27 KB 121.79% (🟢 -0.33%)
/settings/my-account/appearance 283.74 KB 436.88 KB 124.82% (🟢 -0.33%)
/settings/my-account/conferencing 274.25 KB 427.38 KB 122.11% (🟢 -0.36%)
/settings/my-account/general 353.38 KB 506.51 KB 144.72% (🟢 -0.35%)
/settings/my-account/profile 396.49 KB 549.62 KB 157.03% (🟢 -0.34%)
/settings/organizations/appearance 281.1 KB 434.23 KB 124.07% (🟢 -0.29%)
/settings/organizations/general 348.99 KB 502.12 KB 143.46% (🟢 -0.34%)
/settings/organizations/members 380.32 KB 533.45 KB 152.41% (🟢 -0.35%)
/settings/organizations/profile 391 KB 544.13 KB 155.47% (🟢 -0.35%)
/settings/security/impersonation 270.34 KB 423.47 KB 120.99% (🟢 -0.34%)
/settings/security/password 273.55 KB 426.68 KB 121.91% (🟢 -0.35%)
/settings/security/sso 277.81 KB 430.95 KB 123.13% (🟢 -0.36%)
/settings/security/two-factor-auth 272.76 KB 425.89 KB 121.68% (🟢 -0.36%)
/settings/teams 268.15 KB 421.28 KB 120.37% (🟢 -0.35%)
/settings/teams/[id]/appearance 281.11 KB 434.24 KB 124.07% (🟢 -0.28%)
/settings/teams/[id]/billing 268.39 KB 421.52 KB 120.44% (🟢 -0.35%)
/settings/teams/[id]/members 382.6 KB 535.73 KB 153.07% (🟢 -0.36%)
/settings/teams/[id]/onboard-members 176.87 KB 330 KB 94.29% (🟢 -0.28%)
/settings/teams/[id]/profile 459.9 KB 613.03 KB 175.15% (🟢 -0.20%)
/settings/teams/[id]/sso 277.91 KB 431.04 KB 123.15% (🟢 -0.35%)
/settings/teams/new 216.24 KB 369.37 KB 105.54% (🟢 -0.35%)
/teams 262.64 KB 415.77 KB 118.79% (🟢 -0.34%)
/workflows 274.94 KB 428.07 KB 122.31% (🟢 -0.35%)
/workflows/[workflow] 383.79 KB 536.93 KB 153.41% (🟢 -0.47%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good 🙏

@CarinaWolli CarinaWolli merged commit 647ba8c into calcom:main Jun 30, 2023
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working Low priority Created by Linear-GitHub Sync organizations area: organizations, orgs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-2076] /settings/profile - if you try save without name the error message copy needs updated

2 participants