feat: Make Team Private

[Udit-takkar]

What does this PR do?

Fixes #8974

1. When user is admin

2. When user is not admin and team is private

Type of change

• New feature (non-breaking change which adds functionality)

How should this be tested?

1. go to Team members page and turn on switch Make Team Private.

Now after making the team private only admin would be able to see all the members list in the settings. There will not be a button to Book a team member instead on the team page like before.

Mandatory Tasks

• Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 19, 2024 2:47pm
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 19, 2024 2:47pm
web-staging	🔄 Building (Inspect)			Mar 19, 2024 2:47pm

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
dev	⬜️ Ignored (Inspect)			Mar 19, 2024 2:47pm
ui	⬜️ Ignored (Inspect)	Visit Preview		Mar 19, 2024 2:47pm

[github-actions]

Thank you for following the naming conventions! 🙏

[github-actions]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (350 KB)
/settings/organizations/appearance	282.09 KB	435.45 KB	124.41% (🟡 +0.53%)
/settings/teams/[id]/onboard-members	177.82 KB	331.18 KB	94.62% (🟡 +0.18%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

[deploysentinel]

Current Playwright Test Results Summary

✅ 124 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/03/2023 01:39:59pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 79b5c33

Started: 07/03/2023 01:38:09pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null	3 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests -- new-booker should be able to reschedule Retry 1 • Initial Attempt	12.30% (15) 15 / 122 runs failed over last 7 days	45.90% (56) 56 / 122 runs flaked over last 7 days
Popup Tests -- new-booker should open Routing Forms embed on click Retry 1 • Initial Attempt	0% (0) 0 / 122 runs failed over last 7 days	12.30% (15) 15 / 122 runs flaked over last 7 days
Popup Tests -- old-booker should open embed iframe on click - Configured with light theme Retry 1 • Initial Attempt	0.82% (1) 1 / 122 run failed over last 7 days	31.15% (38) 38 / 122 runs flaked over last 7 days

---

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download Retry 1 • Initial Attempt	3.07% (5) 5 / 163 runs failed over last 7 days	34.97% (57) 57 / 163 runs flaked over last 7 days

---

View Detailed Build Results

---

[Udit-takkar]

@Jaibles can you create a design for this page ? ( When a team is marked private but user still try to go the url of "Book a team member instead" Button on the team's page)

[pumfleet]

Code looks good to me

[pumfleet]

@baileypumfleet merged this pull request with Graphite.

[PeerRich]

@Jaibles can you create a design for this page ? ( When a team is marked private but user still try to go the url of "Book a team member instead" Button on the team's page)

this is good enough for sure. rarely people will visit this