fix: Transform Google API Key [CAL-1749]#9890
Conversation
CAL-1749 Adding gCal via /admin/apps fails when parsing back
This is the error in the console The issue it that when we're saving |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Thank you for following the naming conventions! 🙏 |
| z | ||
| .string() | ||
| .url() | ||
| .transform((url) => [url]), |
There was a problem hiding this comment.
When submitting keys, we parse the input so it would automatically transform the redirect_uris to an array. So we either accept an array or a single string and transform it into an array.
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 111 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/03/2023 05:32:25am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 4ca7ada Started: 07/03/2023 05:30:44am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Change Theme Test change theme to dark
Retry 1 • Initial Attempt |
0.94% (2)2 / 213 runsfailed over last 7 days |
4.23% (9)9 / 213 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Pending payment booking should not be confirmed by default
Retry 1 • Initial Attempt |
0% (0)0 / 32 runsfailed over last 7 days |
12.50% (4)4 / 32 runsflaked over last 7 days |
📄 apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Embed Code Generator Tests Event Types Page open Embed Dialog and choose floating-popup for First Event Type
Retry 1 • Initial Attempt |
0% (0)0 / 217 runsfailed over last 7 days |
5.53% (12)12 / 217 runsflaked over last 7 days |
What does this PR do?
This PR fixes when an admin is adding API credentials in the "Apps" section of the admin settings for GCal, it will parse the
redirect_uristo an array of strings.Fixes #9079
Type of change
How should this be tested?
redirect_urisshould be an arrayMandatory Tasks
Checklist