Conversation
Fixes API build failure introduced after #9291
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
zomars
commented
Jul 4, 2023
| const { prisma, isCustomPrisma, isAdmin } = req; | ||
| const hasValidLicense = await checkLicense(prisma); | ||
| if (!hasValidLicense) | ||
| if (!hasValidLicense && process.env.NODE_ENV !== "development") |
Contributor
Author
There was a problem hiding this comment.
So we can test API on development
| return await publishHandler({ input: { teamId }, ctx: { ...ctx, user } }); | ||
| const caller = viewerTeamsRouter.createCaller(ctx); | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| return await caller.publish(req.query as any /* Let tRPC handle this */); |
Contributor
Author
There was a problem hiding this comment.
Usted the same approach we have on slots and confirm link endpoints.
|
|
||
| export const ZPublishInputSchema = z.object({ | ||
| teamId: z.number(), | ||
| teamId: z.coerce.number(), |
Contributor
Author
There was a problem hiding this comment.
By default api paths are strings, so we update to account into this.
zomars
added
🐛 bug
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 101 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/04/2023 05:55:57pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: fad5f4f Started: 07/04/2023 05:53:57pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Change Password Test change password
Retry 1 • Initial Attempt |
0.84% (2)2 / 239 runsfailed over last 7 days |
1.67% (4)4 / 239 runsflaked over last 7 days |
fritterhoff
pushed a commit
to hm-edu/cal.com
that referenced
this pull request
Jul 25, 2023
Fixes API build failure introduced after calcom#9291
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes API build failure introduced after #9291
Type of change
How should this be tested?
yarn dev:apiMandatory Tasks