Skip to content

feat: added missing skeletons for sidebar#9909

Merged
PeerRich merged 1 commit intocalcom:mainfrom
Pradumn27:feat/sidebar-skeletons
Jul 4, 2023
Merged

feat: added missing skeletons for sidebar#9909
PeerRich merged 1 commit intocalcom:mainfrom
Pradumn27:feat/sidebar-skeletons

Conversation

@Pradumn27
Copy link
Copy Markdown
Contributor

What does this PR do?

Have added the missing skeleton in the sidebar

Fixes #9535

Screen.Recording.2023-07-04.at.1.54.56.PM.mov
Screenshot 2023-07-04 at 2 09 14 PM

and this is how it currently is in production :

Screenshot 2023-07-04 at 2 11 15 PM

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • Go to event-types page
  • Toggle your browser network to run on 3g
  • Check for the loading skeletons on the sidebar

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ❌ Failed (Inspect) Jul 4, 2023 8:53am

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 4, 2023

@Pradumn27 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 4, 2023

Thank you for following the naming conventions! 🙏

@github-actions github-actions Bot added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input ✨ feature New feature or request labels Jul 4, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 4, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@PeerRich PeerRich merged commit 2f3cc03 into calcom:main Jul 4, 2023
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ feature New feature or request Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-1952] Add Skeleton for new items in Sidebar

2 participants