Skip to content

fix: premium-username-callback#9938

Merged
emrysal merged 2 commits intomainfrom
fix/premium-username-callback-url
Jul 5, 2023
Merged

fix: premium-username-callback#9938
emrysal merged 2 commits intomainfrom
fix/premium-username-callback-url

Conversation

@alannnc
Copy link
Copy Markdown
Contributor

@alannnc alannnc commented Jul 5, 2023

What does this PR do?

  • Adds full url to stripe callbackUrl

Fixes #9932

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Setup your project constants so your cal.com instance run as a production and not a self host so premium usernames are available
  • Setup website api to be listening
  • Try to update your username to something premium.
  • Do the payment checkout flow
  • Callback url should be working now

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:10pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:10pm
ui ❌ Failed (Inspect) Mar 19, 2024 3:10pm
web-staging 🔄 Building (Inspect) Mar 19, 2024 3:10pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
dev ⬜️ Ignored (Inspect) Mar 19, 2024 3:10pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 5, 2023

Thank you for following the naming conventions! 🙏

Comment thread apps/web/components/ui/UsernameAvailability/PremiumTextfield.tsx
{currentUsername !== inputUsernameValue && (
<div className="absolute right-[2px] top-6 flex flex-row">
<span className={classNames("mx-2 py-2.5")}>
<span className={classNames("mx-2 py-3.5")}>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little visual fix

@alannnc alannnc marked this pull request as ready for review July 5, 2023 02:59
@alannnc alannnc requested a review from zomars July 5, 2023 02:59
@alannnc alannnc assigned emrysal and unassigned emrysal Jul 5, 2023
@alannnc alannnc requested a review from emrysal July 5, 2023 02:59
@alannnc alannnc self-assigned this Jul 5, 2023
@alannnc alannnc added the 🐛 bug Something isn't working label Jul 5, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 5, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jul 5, 2023

Current Playwright Test Results Summary

✅ 127 Passing - ⚠️ 8 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/05/2023 06:19:28pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 365814c

Started: 07/05/2023 06:17:00pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests -- new-booker should be able to reschedule
Retry 1Initial Attempt
15.72% (25) 25 / 159 runs
failed over last 7 days
66.67% (106) 106 / 159 runs
flaked over last 7 days
Popup Tests -- new-booker should open Routing Forms embed on click
Retry 1Initial Attempt
0% (0) 0 / 158 runs
failed over last 7 days
18.35% (29) 29 / 158 runs
flaked over last 7 days
Popup Tests -- old-booker should be able to reschedule
Retry 1Initial Attempt
2.53% (4) 4 / 158 runs
failed over last 7 days
56.33% (89) 89 / 158 runs
flaked over last 7 days

📄   apps/web/playwright/reschedule.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule Tests -- new-booker Opt in event should be PENDING when rescheduled by USER
Retry 1Initial Attempt
1.22% (3) 3 / 246 runs
failed over last 7 days
2.03% (5) 5 / 246 runs
flaked over last 7 days

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to disable 2FA
Retry 1Initial Attempt
0.80% (2) 2 / 251 runs
failed over last 7 days
3.98% (10) 10 / 251 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user -- new-booker can add multiple organizer address
Retry 1Initial Attempt
0.80% (2) 2 / 251 runs
failed over last 7 days
8.76% (22) 22 / 251 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1Initial Attempt
1.75% (3) 3 / 171 runs
failed over last 7 days
35.67% (61) 61 / 171 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Pending payment booking should not be confirmed by default
Retry 1Initial Attempt
2.17% (3) 3 / 138 runs
failed over last 7 days
7.25% (10) 10 / 138 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich PeerRich added Medium priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore. labels Jul 5, 2023
@emrysal emrysal merged commit 816bfdd into main Jul 5, 2023
@emrysal emrysal deleted the fix/premium-username-callback-url branch July 5, 2023 18:19
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working core area: core, team members only Medium priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore.

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

bug: 500 when redirected back from checkout

3 participants