Skip to content

chore: Add missing strings#9943

Merged
emrysal merged 1 commit intomainfrom
add-some-missing-strings-that-i-found-when-browsing-the-website-just-now
Jul 5, 2023
Merged

chore: Add missing strings#9943
emrysal merged 1 commit intomainfrom
add-some-missing-strings-that-i-found-when-browsing-the-website-just-now

Conversation

@pumfleet
Copy link
Copy Markdown
Contributor

@pumfleet pumfleet commented Jul 5, 2023

This is a huge PR that took months of work…

This took all of my engineering experience and expertise…

Please review as this is one of the biggest changes Cal.com has ever seen

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 10:59am
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 10:59am
ui ❌ Failed (Inspect) Jul 5, 2023 10:59am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 5, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 5, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jul 5, 2023

Current Playwright Test Results Summary

✅ 127 Passing - ⚠️ 7 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/05/2023 11:04:00am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: d67e176

Started: 07/05/2023 11:01:10am UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 3 Flakes

Top 1 Common Error Messages

null

3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests -- new-booker should be able to reschedule
Retry 1Initial Attempt
16.22% (24) 24 / 148 runs
failed over last 7 days
64.86% (96) 96 / 148 runs
flaked over last 7 days
Popup Tests -- old-booker should be able to reschedule
Retry 1Initial Attempt
2.72% (4) 4 / 147 runs
failed over last 7 days
55.10% (81) 81 / 147 runs
flaked over last 7 days
Popup Tests -- old-booker should open embed iframe on floating button clicked
Retry 1Initial Attempt
0% (0) 0 / 110 runs
failed over last 7 days
18.18% (20) 20 / 110 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Router URL should work
Retry 1Initial Attempt
0% (0) 0 / 159 runs
failed over last 7 days
6.92% (11) 11 / 159 runs
flaked over last 7 days

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Types Page open Embed Dialog and choose element-click for First Event Type
Retry 1Initial Attempt
0% (0) 0 / 232 runs
failed over last 7 days
4.31% (10) 10 / 232 runs
flaked over last 7 days

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
0.43% (1) 1 / 235 run
failed over last 7 days
6.81% (16) 16 / 235 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
BOOKING_REJECTED can book an event that requires confirmation and then that booking can be rejected by organizer
Retry 1Initial Attempt
0% (0) 0 / 241 runs
failed over last 7 days
2.90% (7) 7 / 241 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich PeerRich changed the title Add missing strings chore: Add missing strings Jul 5, 2023
@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Jul 5, 2023

where is this?

@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Jul 5, 2023

maybe its better to make a new string vs renaming an existing

@pumfleet
Copy link
Copy Markdown
Contributor Author

pumfleet commented Jul 5, 2023

I’m assuming you mean the “yours” string. It’s used in the insights page when you want to see insights for yourself, and I don’t really like it just saying “Yours” so I changed it

@emrysal emrysal merged commit 4ac2c52 into main Jul 5, 2023
@emrysal emrysal deleted the add-some-missing-strings-that-i-found-when-browsing-the-website-just-now branch July 5, 2023 13:12
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants