Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 127 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/05/2023 11:04:00am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: d67e176 Started: 07/05/2023 11:01:10am UTC
|
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests -- new-booker should be able to reschedule
Retry 1 • Initial Attempt |
16.22% (24)24 / 148 runsfailed over last 7 days |
64.86% (96)96 / 148 runsflaked over last 7 days |
|
Popup Tests -- old-booker should be able to reschedule
Retry 1 • Initial Attempt |
2.72% (4)4 / 147 runsfailed over last 7 days |
55.10% (81)81 / 147 runsflaked over last 7 days |
|
Popup Tests -- old-booker should open embed iframe on floating button clicked
Retry 1 • Initial Attempt |
0% (0)0 / 110 runsfailed over last 7 days |
18.18% (20)20 / 110 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
0% (0)0 / 159 runsfailed over last 7 days |
6.92% (11)11 / 159 runsflaked over last 7 days |
📄 apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Embed Code Generator Tests Event Types Page open Embed Dialog and choose element-click for First Event Type
Retry 1 • Initial Attempt |
0% (0)0 / 232 runsfailed over last 7 days |
4.31% (10)10 / 232 runsflaked over last 7 days |
📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
0.43% (1)1 / 235 runfailed over last 7 days |
6.81% (16)16 / 235 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
BOOKING_REJECTED can book an event that requires confirmation and then that booking can be rejected by organizer
Retry 1 • Initial Attempt |
0% (0)0 / 241 runsfailed over last 7 days |
2.90% (7)7 / 241 runsflaked over last 7 days |
Member
|
where is this? |
Member
|
maybe its better to make a new string vs renaming an existing |
Contributor
Author
|
I’m assuming you mean the “yours” string. It’s used in the insights page when you want to see insights for yourself, and I don’t really like it just saying “Yours” so I changed it |
emrysal
approved these changes
Jul 5, 2023
emrysal
deleted the
add-some-missing-strings-that-i-found-when-browsing-the-website-just-now
branch
fritterhoff
pushed a commit
to hm-edu/cal.com
that referenced
this pull request
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a huge PR that took months of work…
This took all of my engineering experience and expertise…
Please review as this is one of the biggest changes Cal.com has ever seen