Skip to content

fix: Preview deployements don't have NEXT_PUBLIC_WEBAPP_URL defined#9969

Merged
emrysal merged 1 commit intomainfrom
bugfix/fix-preview-deployments
Jul 6, 2023
Merged

fix: Preview deployements don't have NEXT_PUBLIC_WEBAPP_URL defined#9969
emrysal merged 1 commit intomainfrom
bugfix/fix-preview-deployments

Conversation

@emrysal
Copy link
Copy Markdown
Contributor

@emrysal emrysal commented Jul 6, 2023

What does this PR do?

We fallback similarly in next.config.js - but this code is ran before that happens - so we need to fallback explicitly here.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 5:53pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 5:53pm
ui ❌ Failed (Inspect) Jul 6, 2023 5:53pm

@emrysal emrysal requested a review from joeauyeung July 6, 2023 17:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 6, 2023

Thank you for following the naming conventions! 🙏

@zomars zomars added ci area: CI, DX, pipeline, github actions core area: core, team members only labels Jul 6, 2023
@emrysal emrysal changed the title Default to VERCEL_URL fix: Preview deployements don't have NEXT_PUBLIC_WEBAPP_URL defined Jul 6, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 6, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jul 6, 2023

Current Playwright Test Results Summary

✅ 127 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/06/2023 05:58:18pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 3383ce5

Started: 07/06/2023 05:56:01pm UTC

⚠️ Flakes

📄   apps/web/playwright/reschedule.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule Tests -- old-booker Attendee should be able to reschedule a booking
Retry 1Initial Attempt
0.39% (1) 1 / 257 run
failed over last 7 days
8.95% (23) 23 / 257 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests -- new-booker should be able to reschedule
Retry 1Initial Attempt
15.98% (27) 27 / 169 runs
failed over last 7 days
75.15% (127) 127 / 169 runs
flaked over last 7 days
Popup Tests -- old-booker should be able to reschedule
Retry 1Initial Attempt
2.98% (5) 5 / 168 runs
failed over last 7 days
66.67% (112) 112 / 168 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 2Retry 1Initial Attempt
0.53% (1) 1 / 188 run
failed over last 7 days
37.77% (71) 71 / 188 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
BOOKING_REJECTED can book an event that requires confirmation and then that booking can be rejected by organizer
Retry 1Initial Attempt
0% (0) 0 / 275 runs
failed over last 7 days
2.91% (8) 8 / 275 runs
flaked over last 7 days

View Detailed Build Results


@emrysal emrysal merged commit fbb27ce into main Jul 6, 2023
@emrysal emrysal deleted the bugfix/fix-preview-deployments branch July 6, 2023 18:01
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci area: CI, DX, pipeline, github actions core area: core, team members only

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants