Full redesign of the application & code simplify #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NavigationView now has one graident used for background which is kept between the navigation events. For that reason all backgrounds were removed from all other pages in the application so they do not override the main background.
The UserAccount will no longer be available in the application as it will not support loggin system nor user customized notes. Once you open the application, it will have all the notes as created by one user.
The FlatList containing all the notes created in the application were previously being rerendered each time the window's size changed. This has been optimized by handling the whole database fetch procedure in the main notes screen instead of delegating it into each note widget. The current solution is that when NotesScreen page loads the database returns the full set of notes already packed as objects. This is returned as a Promise, which allows to render each note separately and only then fill them with data.
Unfortunatelly due to the usage of external libraries (datetimepicker) which does not support ARM devices builds, the CI did not pass for this architecture. To keep the CI reliable (without false-negative red notifications) the ARM builds are removed from the workflow.
The issue with first note created in the system was that it was omitted during the database fetch. This was caused by the ID being indexed from 1 instead of 0. To fix that, the ID of new note is set to the number of notes already created.
The new design does not include the application settings so it should be removed instead of keeping it empty. Moreover, there's no configuration that could be done in the settings.
The full redesign of the JS side (RN side) of the application includes: * Removed unused code * Improved buttons layout and behavior - buttons no longer have their black background when pressed and their space is adjusted to the current layout instead of reserving pixels * Colors improved * Better and simplier widgets size adjustments This is done by removing the calculations of height and width of panels based on window's dimension, but instead it's done by built-in percentage values * Deletion and cancelation buttons improved They contains now simple messages easy to understand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes #13
It completely redesigns the application.
The redesign contains
major changes:
minor changes:
The results are as follows:
For more information please check the commit messages.