Notes screen and note details page implementation #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The application's main panel contains all the notes added by the user. They are displayed in the grid, with number of columns adapted to the width of the window. Note, that the Window size needs to be considered instead of Screen's. That is due to having the Page in RNW rendered as a root with certain and fixed dimensions. Currently only the testing data are given to the FlatList, so there's a possibility to test it by displaying any content. In further development that data should be taken from the database.
This commit introduces the initial widget containing single note presented on the main panel. This widget has the reponsibility to: * contain the summary of the note: ID, Title and shortened post message * act as the button to enter the full post screen
This native module is responsible for handling the navigation between screens which are not connected through the NavigationView and it's Frame. This situation happens, when there's a need to navigate to separate screen, but at the same time get rid of navigation panel. This native module is called NoteWidgetClickHandler because it is designed explicitly for the NotesPage <-> NoteWidgetDetailsPage navigation both-ways.
The native module should also provide the system with the ability to go back. This is now done by the GoToNotesScreen function, which navigates to the MainPage. NOTE: MainPage needs to be selected, as only this page contains the NavigationFrame and is able to display the navigation top pane. This is why there's a starting point implemented when MainPage is navigated to.
BartoszKlonowski
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the main application's page basic behavior:
It allows to navigate across the Notes panel and go deeper into the Note details page.
There are three main functionalities included in this implementation:
This allows to remove the navigation top pane when navigating deeper into the Note details.
The "deeper" is done by setting the navigation animation to the Drill mode, so there's a feel of going deeper into the application.
So, regarding the basic layout implementation, this pull request mostly relates to the selected part of the application system:
For more details about the implementation please check the commit messages.
The result of this pull request is as presented on the animation below.
Note that some colors are damaged by the GIF compression, there's also the lag when changing the window's dimensions.