Skip to content

feat: add a safeAreaInsets prop to bottom navigation#2746

Merged
lukewalczak merged 1 commit intomainfrom
@satya164/bottom-navigation-insets
May 27, 2021
Merged

feat: add a safeAreaInsets prop to bottom navigation#2746
lukewalczak merged 1 commit intomainfrom
@satya164/bottom-navigation-insets

Conversation

@satya164
Copy link
Copy Markdown
Member

No description provided.

@satya164 satya164 requested a review from lukewalczak May 26, 2021 11:40
@callstack-bot
Copy link
Copy Markdown

Hey @satya164, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@github-actions
Copy link
Copy Markdown

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak merged commit 0d71218 into main May 27, 2021
@lukewalczak lukewalczak deleted the @satya164/bottom-navigation-insets branch May 27, 2021 14:51
},
items: {
flexDirection: 'row',
width: '100%',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks tabs on the web.

Before:
image

After:
image

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SleeplessByte can you send a PR conditionally adding this style on Web?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesh, sure.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants