feat: banner, add optional callback for on animation complete#2758
Merged
brunohkbx merged 6 commits intocallstack:mainfrom Oct 22, 2021
Merged
feat: banner, add optional callback for on animation complete#2758brunohkbx merged 6 commits intocallstack:mainfrom
brunohkbx merged 6 commits intocallstack:mainfrom
Conversation
|
Hey @daniel112, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
Hello 👋, this pull request has been open for more than 2 months with no activity on it. If you think this is still necessary with the latest version, please comment and ping a maintainer to get this reviewed, otherwise it will be closed automatically in 7 days. |
Contributor
Author
lukewalczak
requested changes
Aug 11, 2021
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
lukewalczak
approved these changes
Sep 20, 2021
Collaborator
|
hey @daniel112 can you please fix the conflicts? |
Contributor
Author
done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After using the Banner component, for better flexibility for customization, I find that it could be useful for consumers to hook into the callback for when the default animation completes.
i.e doing some action after the banner is completely gone as opposed to during animation after setting
visible=falseTest plan
I've modified the Banner example to log out whenever it completes the
open/closeanimation. If that is not a preferred modification to examples then you can test by:BannerExample.tsxforonAnimateShowFinishand/oronAnimateHideFinishcallbacks