fix: comply to eslint warnings in example files#2946
Merged
lukewalczak merged 1 commit intomainfrom Oct 22, 2021
Merged
Conversation
|
The mobile version of example app from this branch is ready! You can see it here |
lukewalczak
approved these changes
Oct 22, 2021
Member
lukewalczak
left a comment
lukewalczak
left a comment
There was a problem hiding this comment.
Thanks @p-syche for reducing the number of warnings!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a continuation of efforts to remove eslint warnings, started in PR #2941.
This specific PR tackles example files.
I also changed styles/colors.tsx in order to add a
transparentcolor. I went with a white with 100% opacity (in the form ofrgba(255,255,255,0)).The current state of eslint warnings on the
mainbranch:This PR fixes 21 warnings 🎉