fix: correct Chip touchable style#2976
Merged
lukewalczak merged 2 commits intomainfrom Dec 10, 2021
Merged
Conversation
|
The mobile version of example app from this branch is ready! You can see it here |
Collaborator
|
Thanks @lukewalczak. I didn't realize that using |
Member
Author
|
@brunohkbx sure, good point! Will add it! |
Member
Author
|
After the research I guess we are not able to test the regression without e2e tests. Snapshot indicates only change from |
brunohkbx
approved these changes
Nov 16, 2021
|
Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
The mobile version of example app from this branch is ready! You can see it here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2972, #2959
Summary
Setting the
flexGrowtoTouchablewithinChipat the same time it's not breaking the previous issue: #2804
Test plan
Run the code below from one of the issues and expect Chips are displayed properly: