fix: correct clickthrough on web tabs within BottomNavigation#2985
Merged
lukewalczak merged 1 commit intomainfrom Dec 10, 2021
Merged
fix: correct clickthrough on web tabs within BottomNavigation#2985lukewalczak merged 1 commit intomainfrom
lukewalczak merged 1 commit intomainfrom
Conversation
|
The mobile version of example app from this branch is ready! You can see it here |
p-syche
approved these changes
Nov 30, 2021
Contributor
p-syche
left a comment
p-syche
left a comment
There was a problem hiding this comment.
LGTM 😄
I left a question about naming convention - why not use index.tsx? - but that's no reason to hold off on approving this.
| import { Text } from 'react-native'; | ||
| import PaperProvider from "react-native-paper/lib/module/core/Provider"; | ||
| import BottomNavigation from "react-native-paper/lib/module/components/BottomNavigation"; | ||
| import BottomNavigation from "react-native-paper/lib/module/components/BottomNavigation/BottomNavigation"; |
Contributor
There was a problem hiding this comment.
Why not rename the new file to index.tsx so you would avoid this change?
Member
Author
There was a problem hiding this comment.
Hey @p-syche, sorry for the late response. Basically, I keep the convention where each file has the component name and index.ts is used when we are assigning sub components.
This was referenced Dec 10, 2021
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2366
The PR bases on the approach started within #2548, however fixes the problem with animation during the transtions.
Test steps are the same as in the linked PR above.
Summary
Test plan
Clone the branch, install dependencies with
yarn bootstrapandyarn link. Test expo snack online with instructions in the app and see the issue. Download expo snack to a folder (https://snack.expo.io/@jasperro/react-native-paper-tab-clickthrough-test) and runyarnandyarn link react-native-paper, and it should be fixed.