feat: adjust typography component, fix theme types#3066
Merged
lukewalczak merged 13 commits intonextfrom Feb 2, 2022
Merged
Conversation
Drakeoon
force-pushed
the
feat/adjust-typography-component
branch
from
cb2a5c9 to
d8f980b
Compare
Drakeoon
changed the title
Drakeoon
commented
Feb 2, 2022
Comment on lines
-37
to
-69
| const CustomDarkTheme = { | ||
| ...DarkTheme, | ||
| colors: { | ||
| ...DarkTheme.colors, | ||
| customColor: '#BADA55', | ||
| }, | ||
| fonts: { | ||
| ...DarkTheme.fonts, | ||
| superLight: { ...DarkTheme.fonts['light'] }, | ||
| }, | ||
| animation: { | ||
| ...DarkTheme.animation, | ||
| customProperty: 1, | ||
| }, | ||
| }; | ||
|
|
||
| const CustomDefaultTheme = { | ||
| ...DefaultTheme, | ||
| colors: { | ||
| ...DefaultTheme.colors, | ||
| customColor: '#BADA55', | ||
| }, | ||
| fonts: { | ||
| ...DefaultTheme.fonts, | ||
| superLight: { ...DefaultTheme.fonts['light'] }, | ||
| }, | ||
| userDefinedThemeProperty: '', | ||
| animation: { | ||
| ...DefaultTheme.animation, | ||
| customProperty: 1, | ||
| }, | ||
| }; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@lukewalczak We need to keep that in mind and decide whether we still want to bring it back or maybe instead of this include a section in our docs on how to override themes
Drakeoon
force-pushed
the
feat/adjust-typography-component
branch
from
c1d55c7 to
a5ee163
Compare
Contributor
Author
|
So it turns out our Expo Preview job either doesn't clear cache or uses a different dependency version (@babel/core, @babel/parser?) than when running the build locally. I spoke directly to @lukewalczak and we decided that we will move on and deal with this issue later, as it does not prevent us from developing MD3 components locally. |
lukewalczak
reviewed
Feb 2, 2022
lukewalczak
approved these changes
Feb 2, 2022
Member
lukewalczak
left a comment
lukewalczak
left a comment
There was a problem hiding this comment.
On the next iteration we need to:
- refine the process of overriding themes
- fix Expo Preview jo
lukewalczak
pushed a commit
that referenced
this pull request
Mar 22, 2022
lukewalczak
pushed a commit
that referenced
this pull request
Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new way of approaching typography - a
<Text>component with multiplevariantsthat are Material 3 compliantUsage
<Text variant="heading-large" />Test plan
<Text variant="...">usage)