fix: typescript definition for Button's onPress should have event as argument #3410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This should be done for all components inclusing list.Item e.g. everything with onPress |
Contributor
Author
|
I am ok to make more fixes if I get positive feedback from maintainers. I am a bit surprised that a simple change like this does not get any feedback for a month. Maybe I did something wrong? |
Contributor
|
Me too, maybe as a maintainer directly e.g. via Twitter |
Member
|
Hey @abumalick don't worry, I will review the PR in my spare time |
Member
@RichardLindhout would you like to handle that in the separate PR? |
Contributor
|
@lukewalczak done! |
lukewalczak
changed the title
|
Hey @abumalick, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typescript definition for Button's onPress should have event as argument