feat: getLazy prop for bottom-navigation #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lukewalczak merged 5 commits into main from feat/lazy-bottom-navigation

Oct 31, 2022

Member

hurali97 commented Oct 25, 2022

Summary

Fixes #3085

Introduces getLazy callback prop which allows the user to set lazy for each screen as they want leveraging the route parameter received in the callback. If user wants to set lazy for every screen, they can simply return true from the callback.

Usage:

      <BottomNavigation
        {...otherProps}
        getLazy={({ route }) => route.key !== 'album'}
      />

Test plan

Unit test coverage 🧪

hurali97 added 2 commits

October 25, 2022 13:58


          feat: getLazy prop for bottom-navigation

f007c6e


          test: added test case for getLazy

090cc28

callstack-bot commented Oct 25, 2022 •

edited

Loading

Hey @hurali97, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

lukewalczak added the BottomNavigation label

lukewalczak self-assigned this

github-actions bot commented Oct 25, 2022

The mobile version of example app from this branch is ready! You can see it here

.

1 similar comment

github-actions bot commented Oct 25, 2022

The mobile version of example app from this branch is ready! You can see it here

.

Member

lukewalczak commented Oct 26, 2022

That PR will need the following changes in the material-bottom-tabs repository once the stable version is released.

lukewalczak requested a review from satya164

October 26, 2022 11:12


          refactor: allow lazy prop in Route

9f1ff69

github-actions bot commented Oct 26, 2022

The mobile version of example app from this branch is ready! You can see it here

.


          test: updated unit test for getLazy

2f0f2ba

github-actions bot commented Oct 28, 2022

The mobile version of example app from this branch is ready! You can see it here

.

lukewalczak approved these changes

View reviewed changes

lukewalczak reviewed

View reviewed changes

src/components/BottomNavigation/BottomNavigation.tsx Show resolved Hide resolved


          feat: add annotation

2d0bd13

github-actions bot commented Oct 31, 2022

The mobile version of example app from this branch is ready! You can see it here

.

lukewalczak approved these changes

View reviewed changes

lukewalczak merged commit 61be62a into main

lukewalczak deleted the feat/lazy-bottom-navigation branch

October 31, 2022 11:08

slavikdenis pushed a commit that referenced this pull request


          feat: getLazy prop for bottom-navigation (#3433)

2e94b92

Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>

slavikdenis pushed a commit that referenced this pull request


          feat: getLazy prop for bottom-navigation (#3433)

4ea32f2

Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>

slavikdenis pushed a commit that referenced this pull request


          feat: getLazy prop for bottom-navigation (#3433)

2c3f344

Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>

slavikdenis pushed a commit that referenced this pull request


          feat: getLazy prop for bottom-navigation (#3433)

d9560b7

Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BottomNavigation