fix: export gestureResponderEvent to add preventDefault support on web #3484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also closes #3410 |
Contributor
Author
|
Will solve conflicts |
|
Hey @RichardLindhout, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
Contributor
Author
|
I don't understand how to make this 1 commit. I'm trying to cherry pick but I'm always stuck with that :( |
Contributor
Author
|
@lukewalczak ready :) |
Member
|
Thanks @RichardLindhout for help! Most probably on Monday, I will check your changes |
Member
|
Hey @RichardLindhout, please rebase your PR with |
Contributor
Author
|
@lukewalczak done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I need this to add event.preventDefault on web version of button.
(a I do a href links and need to prevent default behaviour of link but also support SEO + ctrl+click.
Test plan
Running tests