Add Keyboard awareness to BottomNavigation#676
Closed
surajj2223 wants to merge 1 commit intocallstack:masterfrom
surajj2223:master
Closed
Add Keyboard awareness to BottomNavigation#676surajj2223 wants to merge 1 commit intocallstack:masterfrom surajj2223:master
surajj2223 wants to merge 1 commit intocallstack:masterfrom
surajj2223:master
Conversation
|
Hey @surajj2223, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API. |
satya164
added a commit
that referenced
this pull request
Nov 26, 2018
Member
|
Unfortunately, this approach makes it look janky as the bar is visible for a few milliseconds after the keyboard shows up. I created #680 which hides the bar with an animation so it doesn't look as bad. |
Author
|
Thanks @satya164 . Much appreciated ! Hope to see that merged soon. |
satya164
added a commit
that referenced
this pull request
Dec 29, 2018
satya164
added a commit
that referenced
this pull request
Dec 29, 2018
satya164
added a commit
that referenced
this pull request
Dec 29, 2018
satya164
added a commit
that referenced
this pull request
Jan 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Bottom Navigation does not hide when keyboard gets open in case for android with windowSoftInputMode set to adjustResize.