-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(breaking): unify wait for element signature with testing library #327
Merged
thymikee
merged 9 commits into
next
from
feature/unify-waitForElement-signature-with-testing-library
May 18, 2020
Merged
Feat(breaking): unify wait for element signature with testing library #327
thymikee
merged 9 commits into
next
from
feature/unify-waitForElement-signature-with-testing-library
May 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…testing-library # Conflicts: # website/docs/Queries.md
thymikee
reviewed
May 18, 2020
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
thymikee
approved these changes
May 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Needs a rebase |
* Added migration docs section * Added to docosaurus side bar * Updated README * Increased async test timeout * Update website/docs/Migration20.md Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
…testing-library # Conflicts: # typings/__tests__/index.test.tsx # website/docs/Migration20.md
Resolved merge conflicts |
thymikee
deleted the
feature/unify-waitForElement-signature-with-testing-library
branch
May 18, 2020 15:49
thymikee
added a commit
that referenced
this pull request
May 28, 2020
…#327) * Change argument to options object * Renamed `waitForElement` to `waitFor` * Migration guide entry * Fixed typescript check * Update src/helpers/a11yAPI.js Co-authored-by: Michał Pierzchała <thymikee@gmail.com> * (Nearly) Empty migration doc for ver. 2.0 (#326) * Added migration docs section * Added to docosaurus side bar * Updated README * Increased async test timeout * Update website/docs/Migration20.md Co-authored-by: Michał Pierzchała <thymikee@gmail.com> * feat(breaking): remove legacy `debug` export (#328) * Removed global `debug` functions * Removed global `debug` from docs * Cleanup * Added migration section Co-authored-by: Michał Pierzchała <thymikee@gmail.com> Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renamed
waitForElement
towaitFor
and slightly changes signature to match that of React Testing LibrarywaitFor
.Resolves #318
Test plan
Updated all existing tests that uses
waitForElement
to use new new and signature.