feat(breaking): remove legacy debug export
#328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't this leave us with no tests around |
cross19xx
approved these changes
May 18, 2020
|
There are some |
thymikee
approved these changes
May 18, 2020
thymikee
changed the title
debug export
mdjastrzebski
added a commit
that referenced
this pull request
May 18, 2020
thymikee
added a commit
that referenced
this pull request
May 18, 2020
…#327) * Change argument to options object * Renamed `waitForElement` to `waitFor` * Migration guide entry * Fixed typescript check * Update src/helpers/a11yAPI.js Co-authored-by: Michał Pierzchała <thymikee@gmail.com> * (Nearly) Empty migration doc for ver. 2.0 (#326) * Added migration docs section * Added to docosaurus side bar * Updated README * Increased async test timeout * Update website/docs/Migration20.md Co-authored-by: Michał Pierzchała <thymikee@gmail.com> * feat(breaking): remove legacy `debug` export (#328) * Removed global `debug` functions * Removed global `debug` from docs * Cleanup * Added migration section Co-authored-by: Michał Pierzchała <thymikee@gmail.com> Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
thymikee
added a commit
that referenced
this pull request
May 28, 2020
thymikee
added a commit
that referenced
this pull request
May 28, 2020
…#327) * Change argument to options object * Renamed `waitForElement` to `waitFor` * Migration guide entry * Fixed typescript check * Update src/helpers/a11yAPI.js Co-authored-by: Michał Pierzchała <thymikee@gmail.com> * (Nearly) Empty migration doc for ver. 2.0 (#326) * Added migration docs section * Added to docosaurus side bar * Updated README * Increased async test timeout * Update website/docs/Migration20.md Co-authored-by: Michał Pierzchała <thymikee@gmail.com> * feat(breaking): remove legacy `debug` export (#328) * Removed global `debug` functions * Removed global `debug` from docs * Cleanup * Added migration section Co-authored-by: Michał Pierzchała <thymikee@gmail.com> Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove global
debugexport and implementation, in favor ofdebugmethod returned byrender()functions.Resolves #317
Test plan
Removed related tests.