Skip to content

Conversation

@jbroma
Copy link
Member

@jbroma jbroma commented Sep 9, 2025

Summary

Closes #1282

When import: false is set for shared react-native, the same is now applied to its deep imports (react-native/, @react-native/).

Before

shared: {
  react: { singleton: true, eager: false },
  'react-native': { singleton: true, eager: false, import: false },
  // deep imports set automatically by the Re.Pack MF plugin
  'react-native/': { singleton: true, eager: false },
  '@react-native/': { singleton: true, eager: false },
}

After

shared: {
  react: { singleton: true, eager: false, import: false },
  'react-native': { singleton: true, eager: false, import: false },
  // deep imports set automatically by the Re.Pack MF plugin
  'react-native/': { singleton: true, eager: false, import: false },
  '@react-native/': { singleton: true, eager: false, import: false },
}

Test plan

  • - unit tests pass
  • - federation testers work

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2025

🦋 Changeset detected

Latest commit: 407a9de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@callstack/repack Patch
@callstack/repack-plugin-expo-modules Patch
@callstack/repack-plugin-nativewind Patch
@callstack/repack-plugin-reanimated Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
repack-website Ready Ready Preview Comment Sep 9, 2025 3:42pm

@jbroma jbroma changed the title fix: pin emitting RN deep imports shared chunks to RN fix: pin emitting RN deep imports shared to RN shared Sep 9, 2025
@jbroma jbroma merged commit 1e6cd16 into main Sep 9, 2025
6 checks passed
@jbroma jbroma deleted the fix/propagate-import-false-to-shared-rn branch September 9, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MiniApp: Build command generates large chunk file ~350kb

2 participants