Skip to content

Conversation

@rinej
Copy link
Collaborator

@rinej rinej commented Oct 3, 2025

Adding keystore-path param for custom keystore locations

@rinej rinej requested a review from Copilot October 3, 2025 10:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new keystore-path input parameter to allow customization of the keystore file location within Android projects. Previously, the keystore was hardcoded to release.keystore in the app directory.

Key changes:

  • Added configurable keystore path parameter with a default value of release.keystore
  • Updated keystore operations to use the configurable path instead of hardcoded values
  • Added proper directory creation and error handling for custom keystore locations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
action.yml Added keystore-path input parameter and updated keystore handling logic to use configurable paths
README.md Updated documentation to include the new keystore-path parameter in usage examples and inputs table

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

README.md Outdated
| `keystore-store-password` | Keystore store password | No | - |
| `keystore-key-alias` | Keystore key alias | No | - |
| `keystore-key-password` | Keystore key password | No | - |
| `keystore-path` | Path for keystore | No | `release.keystore` |
Copy link

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description 'Path for keystore' is unclear. It should specify that this is the path within the Android source directory where the keystore should be placed, matching the description in action.yml.

Suggested change
| `keystore-path` | Path for keystore | No | `release.keystore` |
| `keystore-path` | Path within the Android source directory where the keystore should be placed | No | `release.keystore` |

Copilot uses AI. Check for mistakes.
cursor[bot]

This comment was marked as outdated.

@rinej rinej requested a review from thymikee October 3, 2025 10:54
@thymikee thymikee merged commit e8cf87f into main Oct 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants