Skip to content

fix: support for special characters in profiles names #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 15, 2025
Merged

fix: support for special characters in profiles names #19

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b90708f
add support form special char in the profiles names
rinej Oct 8, 2025
29e2f8c
use printf to support special characters
rinej Oct 8, 2025
e33de1b
fix: use variable to support multiline string
rinej Oct 9, 2025
6ee54ff
fix: add quotes in resign paths
rinej Oct 15, 2025
c70432d
chore: fix formatting
rinej Oct 15, 2025
69e6797
chore: fix fomatting
rinej Oct 15, 2025
79778c5
Merge branch 'main' into feat/support-for-special-characters-in-profi…
rinej Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 35 additions & 31 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ runs:
fi
fi


# Legacy provisioning profile validation (only when not using provisioning-profiles)
if [ -z "${{ inputs.provisioning-profiles }}" ]; then
PROVISIONING_PROFILES='${{ inputs.provisioning-profiles }}'
if [ -z "$PROVISIONING_PROFILES" ]; then
if [ -n "${{ inputs.provisioning-profile-file }}" ] && [ -n "${{ inputs.provisioning-profile-base64 }}" ]; then
echo "Cannot specify both 'provisioning-profile-file' and 'provisioning-profile-base64'. Use one or the other."
exit 1
Expand All @@ -118,46 +118,45 @@ runs:
fi
fi
fi

# Check if either provisioning-profile-name or provisioning-profiles is provided
if [ -z "${{ inputs.provisioning-profile-name }}" ] && [ -z "${{ inputs.provisioning-profiles }}" ]; then
if [ -z "${{ inputs.provisioning-profile-name }}" ] && [ -z "$PROVISIONING_PROFILES" ]; then
echo "Either 'provisioning-profile-name' or 'provisioning-profiles' is required for device builds."
exit 1
fi
if [ -n "${{ inputs.provisioning-profile-name }}" ] && [ -n "${{ inputs.provisioning-profiles }}" ]; then

if [ -n "${{ inputs.provisioning-profile-name }}" ] && [ -n "$PROVISIONING_PROFILES" ]; then
echo "Cannot specify both 'provisioning-profile-name' and 'provisioning-profiles'. Use one or the other."
exit 1
fi


# Validate provisioning profiles if provided
if [ -n "${{ inputs.provisioning-profiles }}" ]; then
while read -r profile; do
name=$(echo "$profile" | jq -r '.name')
file_path=$(echo "$profile" | jq -r '.file // empty')
base64_content=$(echo "$profile" | jq -r '.base64 // empty')
if [ -n "$PROVISIONING_PROFILES" ]; then
while IFS= read -r profile; do
name="$(echo "$profile" | jq -r '.name')"
file_path="$(echo "$profile" | jq -r '.file // empty')"
base64_content="$(echo "$profile" | jq -r '.base64 // empty')"

if [ -z "$name" ]; then
echo "Provisioning profile missing 'name' field"
exit 1
fi

if [ -n "$file_path" ] && [ -n "$base64_content" ]; then
echo "Cannot specify both 'file' and 'base64' for profile '$name'"
printf "Cannot specify both 'file' and 'base64' for profile: %s\n" "$name"
exit 1
fi

if [ -z "$file_path" ] && [ -z "$base64_content" ]; then
echo "Either 'file' or 'base64' is required for profile '$name'"
printf "Either 'file' or 'base64' is required for profile: %s\n" "$name"
exit 1
fi

if [ -n "$file_path" ] && [ ! -f "$file_path" ]; then
echo "Provisioning profile file not found: '$file_path'"
printf "Provisioning profile file not found: %s\n" "$file_path"
exit 1
fi
done < <(echo "${{ inputs.provisioning-profiles }}" | jq -c '.[]')
done < <(echo "$PROVISIONING_PROFILES" | jq -c '.[]')
fi
fi
shell: bash
Expand Down Expand Up @@ -230,6 +229,9 @@ runs:
- name: Setup Code Signing (device builds only)
if: ${{ inputs.re-sign == 'true' && inputs.destination == 'device' || (!env.ARTIFACT_URL && inputs.destination == 'device') }}
run: |
# Store provisioning profiles input
PROVISIONING_PROFILES='${{ inputs.provisioning-profiles }}'

# Create temporary keychain
KEYCHAIN_PATH=$RUNNER_TEMP/app-signing.keychain-db

Expand All @@ -238,7 +240,6 @@ runs:
KEYCHAIN_PASSWORD=$(openssl rand -base64 32)
fi


security create-keychain -p "$KEYCHAIN_PASSWORD" $KEYCHAIN_PATH
security set-keychain-settings -lut 21600 $KEYCHAIN_PATH
security unlock-keychain -p "$KEYCHAIN_PASSWORD" $KEYCHAIN_PATH
Expand Down Expand Up @@ -299,11 +300,11 @@ runs:
fi

# Setup provisioning profiles
if [ -n "${{ inputs.provisioning-profiles }}" ]; then
while read -r profile; do
name=$(echo "$profile" | jq -r '.name')
file_path=$(echo "$profile" | jq -r '.file // empty')
base64_content=$(echo "$profile" | jq -r '.base64 // empty')
if [ -n "$PROVISIONING_PROFILES" ]; then
while IFS= read -r profile; do
name="$(echo "$profile" | jq -r '.name')"
file_path="$(echo "$profile" | jq -r '.file // empty')"
base64_content="$(echo "$profile" | jq -r '.base64 // empty')"

ADDITIONAL_PROFILE_PATH="$PROFILE_DIR/${name}.mobileprovision"

Expand All @@ -313,8 +314,8 @@ runs:
echo -n "$base64_content" | base64 --decode -o "$ADDITIONAL_PROFILE_PATH"
fi

echo "Installed provisioning profile: $name"
done < <(echo "${{ inputs.provisioning-profiles }}" | jq -c '.[]')
printf "Installed provisioning profile: %s\n" "$name"
done < <(echo "$PROVISIONING_PROFILES" | jq -c '.[]')
fi
shell: bash

Expand Down Expand Up @@ -388,7 +389,7 @@ runs:
- name: Re-sign IPA
if: ${{ env.ARTIFACT_URL && inputs.destination == 'device' && inputs.re-sign == 'true' }}
run: |
npx rock sign:ios ${{ env.ARTIFACT_PATH }} \
npx rock sign:ios "${{ env.ARTIFACT_PATH }}" \
--build-jsbundle \
--identity ${{ env.IDENTITY }}
shell: bash
Expand All @@ -397,7 +398,7 @@ runs:
- name: Re-bundle APP
if: ${{ env.ARTIFACT_URL && inputs.destination == 'simulator' && inputs.re-sign == 'true' }}
run: |
npx rock sign:ios ${{ env.ARTIFACT_TAR_PATH }} \
npx rock sign:ios "${{ env.ARTIFACT_TAR_PATH }}" \
--build-jsbundle \
--app
shell: bash
Expand Down Expand Up @@ -474,6 +475,9 @@ runs:
- name: Clean Up Code Signing (device builds only)
if: ${{ inputs.re-sign == 'true' && inputs.destination == 'device' || (!env.ARTIFACT_URL && inputs.destination == 'device') }}
run: |
# Store provisioning profiles input
PROVISIONING_PROFILES='${{ inputs.provisioning-profiles }}'

KEYCHAIN_PATH=$RUNNER_TEMP/app-signing.keychain-db
security delete-keychain "$KEYCHAIN_PATH"

Expand All @@ -488,14 +492,14 @@ runs:
fi

# Clean up provisioning profiles
if [ -n "${{ inputs.provisioning-profiles }}" ]; then
if [ -n "$PROVISIONING_PROFILES" ]; then
PROFILE_DIR="$HOME/Library/MobileDevice/Provisioning Profiles"
while read -r profile; do
name=$(echo "$profile" | jq -r '.name')
while IFS= read -r profile; do
name="$(echo "$profile" | jq -r '.name')"
PROFILE_PATH="$PROFILE_DIR/${name}.mobileprovision"
rm "$PROFILE_PATH"
echo "Cleaned up additional provisioning profile: $name"
done < <(echo "${{ inputs.provisioning-profiles }}" | jq -c '.[]')
printf "Cleaned up provisioning profile: %s\n" "$name"
done < <(echo "$PROVISIONING_PROFILES" | jq -c '.[]')
fi
shell: bash

Expand Down