feat: Add badge color support for Android #473
Conversation
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt
Show resolved
Hide resolved
- Add badgeBackgroundColor and badgeTextColor props to TabView - Implement badge styling in Android native code using Material BadgeDrawable API - Add support in @bottom-tabs/react-navigation wrapper - Colors are processed using processColor for proper color conversion - Properly reset colors to theme defaults when props are removed (fixes stale color bug) - Android only feature (iOS uses system default badge styling)
prateekchachra-aily
force-pushed
the
feat/add-badge-color-support-android
branch
from
e2af737 to
3f98bab
Compare
okwasniewski
left a comment
okwasniewski
left a comment
There was a problem hiding this comment.
Thanks for creating this PR, can you also update the documentation with your changes?
Done, added the docs. |
|
since this PR is released with 1.0.3 im seeing a bunch of unresolved references with RN 0.81 and the data class TabInfo is indeed missing on these new references introduced in this PR 
|
Same here. Build failing cc @okwasniewski |
|
@migueldaipre @lovegaoshi I can create a separate PR to add the references if need be, it never gave an error to me even while building |
|
i think the best course forward then would be me or miguel add the
properties in the dataclass ourselves and see if it goes away, since u cant
reproduce it.
if its only us having this issue we probably just configured it wrong.
still would appreciate to know where it went wrong
…On Wed, Dec 3, 2025, 1:21 AM Prateek Chachra ***@***.***> wrote:
*prateekchachra-aily* left a comment
(callstack/react-native-bottom-tabs#473)
<#473 (comment)>
@migueldaipre <https://github.com/migueldaipre> @lovegaoshi
<https://github.com/lovegaoshi> I can create a separate PR to add the
references if need be, it never gave an error to me even while building
—
Reply to this email directly, view it on GitHub
<#473 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZMOVVXYHDPMQGVUDJSH5FD372TRTAVCNFSM6AAAAACMVKTUUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMBVHA2TSNZQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
|
The issue has been fixed in #482 |
4 participants
PR Description
Adds support for customizing badge colors on Android tabs using the Material Design
BadgeDrawableAPI.How to test?
tabBarBadgeBackgroundColorandtabBarBadgeTextColorin screen optionsScreenshots
(Example with background color
#1FAand text color white)Note
Adds Android-only support to set tab badge background and text colors, with wiring through TabView and @react-navigation wrapper and theme fallbacks when unset.
RCTTabView.kt):badgeBackgroundColorandbadgeTextColoron badges; reset to theme defaults (colorError,colorOnError) when unset.react-native-bottom-tabs):TabViewaddsgetBadgeBackgroundColor/getBadgeTextColor; values processed viaprocessColorand passed initems.TabViewNativeComponent.ts) and route types (types.ts) extended with badge color fields.react-navigation):tabBarBadgeBackgroundColor,tabBarBadgeTextColor.NativeBottomTabViewwires these options toTabViewgetters.Written by Cursor Bugbot for commit 042f674. This will update automatically on new commits. Configure here.