Fix lint issues

Author: kraenhansen

apps/test-app/App.tsx

@@ -41,7 +41,10 @@ function loadTests({
           it(exampleName, async () => {
             const test = requireExample();
             if (test instanceof Function) {
-              await test();
+              const result = test();
+              if (result instanceof Promise) {
+                await result;
+              }
             }
           });
         }
@@ -67,8 +70,9 @@ function loadTests({
 
   describeIf(ferricExample, "ferric-example", () => {
     it("exports a callable sum function", () => {
-      /* eslint-disable-next-line @typescript-eslint/no-require-imports -- TODO: Determine why a dynamic import doesn't work on Android */
-      const exampleAddon = require("ferric-example");
+      const exampleAddon =
+        /* eslint-disable-next-line @typescript-eslint/no-require-imports -- TODO: Determine why a dynamic import doesn't work on Android */
+        require("ferric-example") as typeof import("ferric-example");
       const result = exampleAddon.sum(1, 3);
       if (result !== 4) {
         throw new Error(`Expected 1 + 3 to equal 4, but got ${result}`);

packages/cmake-rn/src/platforms.ts

@@ -18,6 +18,11 @@ export function findPlatformForTarget(target: unknown) {
   const platform = Object.values(platforms).find((platform) =>
     platformHasTarget(platform, target),
   );
-  assert(platform, `Unable to determine platform from target: ${target}`);
+  assert(
+    platform,
+    `Unable to determine platform from target: ${
+      typeof target === "string" ? target : JSON.stringify(target)
+    }`,
+  );
   return platform;
 }

packages/cmake-rn/src/weak-node-api.ts

@@ -37,7 +37,7 @@ export function getWeakNodeApiPath(triplet: SupportedTriplet): string {
     assert(fs.existsSync(libraryPath), `Expected library at ${libraryPath}`);
     return libraryPath;
   } else {
-    throw new Error(`Unexpected triplet: ${triplet}`);
+    throw new Error(`Unexpected triplet: ${triplet as string}`);
   }
 }
 

packages/ferric/src/cargo.ts

@@ -223,6 +223,6 @@ export function getTargetEnvironmentVariables({
       ].join(String.fromCharCode(0x1f)),
     };
   } else {
-    throw new Error(`Unexpected target: ${target}`);
+    throw new Error(`Unexpected target: ${target as string}`);
   }
 }

packages/ferric/src/targets.ts

@@ -99,6 +99,6 @@ export function filterTargetsByPlatform(
   } else if (platform === "apple") {
     return [...targets].filter(isAppleTarget);
   } else {
-    throw new Error(`Unexpected platform ${platform}`);
+    throw new Error(`Unexpected platform ${platform as string}`);
   }
 }

packages/gyp-to-cmake/src/cli.ts

@@ -78,6 +78,6 @@ export const program = new Command("gyp-to-cmake")
     } else if (stat.isDirectory()) {
       transformBindingGypsRecursively(targetPath, options);
     } else {
-      throw new Error(`Expected either a file or a directory: ${path}`);
+      throw new Error(`Expected either a file or a directory: ${targetPath}`);
     }
   });

packages/host/scripts/node-api-functions.ts

@@ -51,7 +51,7 @@ export function getNodeApiHeaderAST(version: NodeApiVersion) {
       maxBuffer: 1024 * 1024 * 10,
     },
   );
-  const parsed = JSON.parse(output);
+  const parsed = JSON.parse(output) as unknown;
   return clangAstDump.parse(parsed);
 }
 

packages/host/src/node/babel-plugin/plugin.test.ts

@@ -10,7 +10,7 @@ import { setupTempDirectory } from "../test-utils.js";
 type TestTransformationOptions = {
   files: Record<string, string>;
   inputFilePath: string;
-  assertion(code: string): void;
+  assertion: (code: string) => void;
   options?: PluginOptions;
 };
 

packages/host/src/node/cli/link-modules.ts

@@ -152,6 +152,6 @@ export function getLinkedModuleOutputPath(
   } else if (platform === "apple") {
     return path.join(getAutolinkPath(platform), libraryName + ".xcframework");
   } else {
-    throw new Error(`Unsupported platform: ${platform}`);
+    throw new Error(`Unsupported platform: ${platform as string}`);
   }
 }

packages/host/src/node/cli/program.ts

@@ -38,7 +38,7 @@ function getLinker(platform: PlatformName): ModuleLinker {
   } else if (platform === "apple") {
     return linkXcframework;
   } else {
-    throw new Error(`Unknown platform: ${platform}`);
+    throw new Error(`Unknown platform: ${platform as string}`);
   }
 }
 
@@ -48,7 +48,7 @@ function getPlatformDisplayName(platform: PlatformName) {
   } else if (platform === "apple") {
     return "Apple";
   } else {
-    throw new Error(`Unknown platform: ${platform}`);
+    throw new Error(`Unknown platform: ${platform as string}`);
   }
 }