Skip to content

Conversation

@kraenhansen
Copy link
Collaborator

@kraenhansen kraenhansen commented Sep 13, 2025

Now that we're calling directly into cmake there's no need for the dependency on cmake-js.

@kraenhansen kraenhansen self-assigned this Sep 13, 2025
@kraenhansen kraenhansen added the CMake RN Our `cmake` wrapping CLI label Sep 13, 2025
@kraenhansen kraenhansen requested a review from Copilot September 13, 2025 17:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an unnecessary dependency on cmake-js from the cmake-rn package to clean up the project's dependency tree.

  • Removes the cmake-js dependency from the package.json file
  • Adds a changeset documenting this dependency removal as a patch-level change

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
packages/cmake-rn/package.json Removes the cmake-js dependency from the dependencies list
.changeset/tough-falcons-cheer.md Documents the dependency removal as a patch-level change

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@shirakaba shirakaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤩

@kraenhansen kraenhansen merged commit ad2ec51 into main Sep 14, 2025
6 checks passed
@kraenhansen kraenhansen deleted the kh/cmake-rn/remove-cmake-js-dep branch September 14, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake RN Our `cmake` wrapping CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants