Skip to content

Fix requireNodeAddon return type #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2025
Merged

Fix requireNodeAddon return type #267

merged 1 commit into from
Oct 18, 2025

Conversation

@kraenhansen
Copy link
Collaborator

@kraenhansen kraenhansen commented Oct 17, 2025 •
edited
Loading

Merging this PR will fix #265 by:

  • Refactor host package's react native entrypoint to have its requireNodeAddon function return a generic type T (defaulting to unknown).

@kraenhansen kraenhansen self-assigned this Oct 17, 2025
@kraenhansen kraenhansen added Apple 🍎 Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.) Android 🤖 Anything related to the Android platform (Gradle, NDK, Android SDK) Host 🏡 Our `react-native-node-api-modules` package labels Oct 17, 2025
@kraenhansen kraenhansen merged commit 9f1a301 into main Oct 18, 2025
12 of 13 checks passed
@kraenhansen kraenhansen deleted the kh/require-node-api-return-type branch October 18, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kraenhansen kraenhansen

Labels

Android 🤖 Anything related to the Android platform (Gradle, NDK, Android SDK) Apple 🍎 Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.) Host 🏡 Our `react-native-node-api-modules` package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update return type of requireNodeAddon

2 participants

@kraenhansen